third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html - Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/named-constructor-prototype-chain.html

Issue 2647643002: Fix V8 bindings for named constructors to set prototype object correctly (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 test(function(t)

	6 {

	7 assert_equals(Image.prototype, HTMLImageElement.prototype, "Image.prototype is same as HTMLImageElement.prototype");

	8 assert_equals(new Image().__proto__, HTMLImageElement.prototype, "Image __pr oto__ is HTMLImageElement prototype ");

	9 assert_not_equals(Image.prototype.__proto__, HTMLImageElement.prototype, "Im age.prototype __proto__ is not HTMLImageElement prototype");
	Yuki 2017/01/19 09:57:28 We know that Image.prototype.__proto__ must be HTM We know that Image.prototype.__proto__ must be HTMLElement.prototype, I'd recommend to compare with HTMLElement.prototype. Also, we know that: Image.__proto__ should be HTMLElement Image.name should be "Image" instead of "HTMLImageElement" sashab 2017/01/20 04:37:05 Done. Show quoted text On 2017/01/19 at 09:57:28, Yuki wrote: > We know that Image.prototype.__proto__ must be HTMLElement.prototype, I'd recommend to compare with HTMLElement.prototype. > > Also, we know that: > Image.__proto__ should be HTMLElement > Image.name should be "Image" instead of "HTMLImageElement" Done.
	10 }, "NamedConstructor creates the correct object structure.");

	11 </script>

OLD	NEW