Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2647633003: Removed usage of std::map and std::vector from kernel code. Issue #28064. (Closed)

Created:
3 years, 11 months ago by bkonyi
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removed usage of std::map and std::vector from kernel code. Issue #28064. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/c49eaa19dc8766f9b52bf16bdb629ec7603c5483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -29 lines) Patch
M runtime/vm/kernel_binary.cc View 4 chunks +29 lines, -24 lines 0 comments Download
M runtime/vm/kernel_reader.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bkonyi
3 years, 11 months ago (2017-01-19 17:40:44 UTC) #2
zra
Thanks for taking a look at this! Let's ask Martin and/or Slava to review.
3 years, 11 months ago (2017-01-19 17:54:36 UTC) #4
Vyacheslav Egorov (Google)
thanks! lgtm
3 years, 11 months ago (2017-01-19 18:03:01 UTC) #5
bkonyi
3 years, 11 months ago (2017-01-19 20:11:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c49eaa19dc8766f9b52bf16bdb629ec7603c5483 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698