Support remote installation of extensions and apps.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <set>
 
@@ skipping 526 matching lines @@
   if (pending_extension_info && !pending_extension_info->install_silently())
     client.reset(ExtensionInstallUI::CreateInstallPromptWithProfile(profile_));
 
   scoped_refptr<CrxInstaller> installer(
       CrxInstaller::Create(this, client.Pass()));
   installer->set_expected_id(id);
   int creation_flags = Extension::NO_FLAGS;
   if (pending_extension_info) {
     installer->set_install_source(pending_extension_info->install_source());
     if (pending_extension_info->install_silently())
-      installer->set_allow_silent_install(true);
+      installer->set_allow_silent_install(
+          pending_extension_info->remote_install()
+              ? CrxInstaller::SILENTLY_DONT_GRANT
+              : CrxInstaller::GRANT_SILENTLY);
     creation_flags = pending_extension_info->creation_flags();
     if (pending_extension_info->mark_acknowledged())
       AcknowledgeExternalExtension(id);
   } else if (extension) {
     installer->set_install_source(extension->location());
   }
   // If the extension was installed from or has migrated to the webstore, or
   // its auto-update URL is from the webstore, treat it as a webstore install.
   // Note that we ignore some older extensions with blank auto-update URLs
   // because we are mostly concerned with restrictions on NaCl extensions,
@@ skipping 930 matching lines @@
              extension_prefs_->IsExtensionDisabled(extension->id())) {
     registry_->AddDisabled(extension);
     if (extension_sync_service_)
       extension_sync_service_->SyncExtensionChangeIfNeeded(*extension);
     content::NotificationService::current()->Notify(
         chrome::NOTIFICATION_EXTENSION_UPDATE_DISABLED,
         content::Source<Profile>(profile_),
         content::Details<const Extension>(extension));
 
     // Show the extension disabled error if a permissions increase was the
-    // only reason it was disabled.
-    if (extension_prefs_->GetDisableReasons(extension->id()) ==
-        Extension::DISABLE_PERMISSIONS_INCREASE) {
-      extensions::AddExtensionDisabledError(this, extension);
+    // only reason it was disabled, or if the extensions was remotely installed.
+    int reasons = extension_prefs_->GetDisableReasons(extension->id());
+    if (reasons == Extension::DISABLE_PERMISSIONS_INCREASE ||
+        reasons & Extension::DISABLE_REMOTE_INSTALL) {

[not at google - send to devlin, 2014/05/01 18:55:21]

seems odd to be doing both an == and a & operation on |reasons|.

[Marijn Kruisselbrink, 2014/05/01 22:36:56]

yeah... Actually a more correct check would be to check if one of these two bits
is set, but all other bits are zero. Not sure if that check is any more readable
though.

+      extensions::AddExtensionDisabledError(this, extension, reasons);
     }
   } else if (reloading) {
     // Replace the old extension with the new version.
     CHECK(!registry_->AddDisabled(extension));
     EnableExtension(extension->id());
   } else {
     // All apps that are displayed in the launcher are ordered by their ordinals
     // so we must ensure they have valid ordinals.
     if (extension->RequiresSortOrdinal()) {
       if (!extension->ShouldDisplayInNewTabPage()) {
@@ skipping 914 matching lines @@
 void ExtensionService::UnloadAllExtensionsInternal() {
   profile_->GetExtensionSpecialStoragePolicy()->RevokeRightsForAllExtensions();
 
   registry_->ClearAll();
   system_->runtime_data()->ClearAll();
 
   // TODO(erikkay) should there be a notification for this?  We can't use
   // EXTENSION_UNLOADED since that implies that the extension has been disabled
   // or uninstalled.
 }