Support remote installation of extensions and apps.

chrome/browser/extensions/crx_installer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 58 matching lines @@
  public:
   // Used in histograms; do not change order.
   enum OffStoreInstallAllowReason {
     OffStoreInstallDisallowed,
     OffStoreInstallAllowedFromSettingsPage,
     OffStoreInstallAllowedBecausePref,
     OffStoreInstallAllowedInTest,
     NumOffStoreInstallAllowReasons
   };
 
+  enum AllowSilent {

[not at google - send to devlin, 2014/05/01 18:55:21]

It's confusing me reading things like "allow_silent_install() ==
GRANT_AFTER_PROMPT".

Is there something more abstract that you could have? Like maybe
"InstallBehavior" (probably too generic) or... well, i'll leave you to it.

[Marijn Kruisselbrink, 2014/05/01 22:36:56]

It is clearly confusing me too, considering that I made at least two mistakes
replacing boolean allow_silent_install_ checks with checks for this enum...
 
One way to go might be to just go back to an allow_silent_install_ bool and add
an additional grant_permissions_ bool. But it somehow seemed wrong to use two
bools for something that is only supposed to have three different states...

+    GRANT_AFTER_PROMPT,  // No silent install, show a prompt instead.
+    GRANT_SILENTLY,      // Silently install and grant all permissions.
+    SILENTLY_DONT_GRANT  // Silently install, but don't grant any permissions.
+  };
+
   // Extensions will be installed into service->install_directory(), then
   // registered with |service|. This does a silent install - see below for
   // other options.
   static scoped_refptr<CrxInstaller> CreateSilent(ExtensionService* service);
 
   // Same as above, but use |client| to generate a confirmation prompt.
   static scoped_refptr<CrxInstaller> Create(
       ExtensionService* service,
       scoped_ptr<ExtensionInstallPrompt> client);
 
@@ skipping 34 matching lines @@
   void set_expected_id(const std::string& val) { expected_id_ = val; }
 
   void set_expected_version(const Version& val) {
     expected_version_.reset(new Version(val));
     expected_version_strict_checking_ = true;
   }
 
   bool delete_source() const { return delete_source_; }
   void set_delete_source(bool val) { delete_source_ = val; }
 
-  bool allow_silent_install() const { return allow_silent_install_; }
-  void set_allow_silent_install(bool val) { allow_silent_install_ = val; }
+  AllowSilent allow_silent_install() const { return allow_silent_install_; }
+  void set_allow_silent_install(AllowSilent val) {
+    allow_silent_install_ = val;
+  }
 
   bool is_gallery_install() const {
     return (creation_flags_ & Extension::FROM_WEBSTORE) > 0;
   }
   void set_is_gallery_install(bool val) {
     if (val)
       creation_flags_ |= Extension::FROM_WEBSTORE;
     else
       creation_flags_ &= ~Extension::FROM_WEBSTORE;
   }
@@ skipping 194 matching lines @@
   // temp_dir_, so we don't have to delete it explicitly.
   base::FilePath unpacked_extension_root_;
 
   // True when the CRX being installed was just downloaded.
   // Used to trigger extra checks before installing.
   bool apps_require_extension_mime_type_;
 
   // Allows for the possibility of a normal install (one in which a |client|
   // is provided in the ctor) to procede without showing the permissions prompt
   // dialog.
-  bool allow_silent_install_;
+  AllowSilent allow_silent_install_;
 
   // The value of the content type header sent with the CRX.
   // Ignorred unless |require_extension_mime_type_| is true.
   std::string original_mime_type_;
 
   // What caused this install?  Used only for histograms that report
   // on failure rates, broken down by the cause of the install.
   extension_misc::CrxInstallCause install_cause_;
 
   // Creation flags to use for the extension.  These flags will be used
@@ skipping 33 matching lines @@
 
   // Gives access to common methods and data of an extension installer.
   ExtensionInstaller installer_;
 
   DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_