Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Issue 2647573006: Fix service test script to avoid unhandled exception. (Closed)

Created:
3 years, 11 months ago by Florian Schneider
Modified:
3 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix service test script to avoid unhandled exception. This caused the test to fail sometimes. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1f046952d885ac9ed4d09e5e47c6a0fe8f1b27df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/observatory/tests/service/regress_28443_test.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
3 years, 11 months ago (2017-01-21 00:41:05 UTC) #2
rmacnak
lgtm
3 years, 11 months ago (2017-01-21 00:44:27 UTC) #3
Florian Schneider
3 years, 11 months ago (2017-01-21 00:44:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f046952d885ac9ed4d09e5e47c6a0fe8f1b27df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698