Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2647533002: Force compositing inputs to be clean for getBoundingClientRect (Closed)
Patch Set: For discussion; only do compositing update when in sticky subtree Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index 486a11a43eb50a95648e8c40706d57d7d6d7f796..60dd69c56611df08e64fbab84c577e38d05a9cee 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -104,7 +104,7 @@ bool LayoutBoxModelObject::hasAcceleratedCompositing() const {
}
LayoutBoxModelObject::LayoutBoxModelObject(ContainerNode* node)
- : LayoutObject(node) {}
+ : LayoutObject(node), m_isInStickySubtree(false) {}
bool LayoutBoxModelObject::usesCompositedScrolling() const {
return hasOverflowClip() && hasLayer() &&
@@ -421,6 +421,11 @@ void LayoutBoxModelObject::styleDidChange(StyleDifference diff,
frameView->removeViewportConstrainedObject(this);
}
}
+
+ m_isInStickySubtree =
+ style()->position() == StickyPosition ||
+ (parent() && parent()->enclosingBoxModelObject() &&
+ parent()->enclosingBoxModelObject()->isInStickySubtree());
}
void LayoutBoxModelObject::invalidateStickyConstraints() {

Powered by Google App Engine
This is Rietveld 408576698