Force compositing inputs to be clean for getBoundingClientRect

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
  * All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
@@ skipping 411 matching lines @@
   if (const Attribute* attribute = elementData()->attributes().find(name))
     return attribute->value();
   return nullAtom;
 }
 
 bool Element::shouldIgnoreAttributeCase() const {
   return isHTMLElement() && document().isHTMLDocument();
 }
 
 void Element::scrollIntoView(bool alignToTop) {
-  document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  ensureCompositingInputsClean();
 
   if (!layoutObject())
     return;
 
   bool makeVisibleInVisualViewport =
       !document().page()->settings().getInertVisualViewport();
 
   LayoutRect bounds = boundingBox();
   // Align to the top / bottom and to the closest edge.
   if (alignToTop)
     layoutObject()->scrollRectToVisible(
         bounds, ScrollAlignment::alignToEdgeIfNeeded,
         ScrollAlignment::alignTopAlways, ProgrammaticScroll,
         makeVisibleInVisualViewport);
   else
     layoutObject()->scrollRectToVisible(
         bounds, ScrollAlignment::alignToEdgeIfNeeded,
         ScrollAlignment::alignBottomAlways, ProgrammaticScroll,
         makeVisibleInVisualViewport);
 
   document().setSequentialFocusNavigationStartingPoint(this);
 }
 
 void Element::scrollIntoViewIfNeeded(bool centerIfNeeded) {
-  document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  ensureCompositingInputsClean();
 
   if (!layoutObject())
     return;
 
   bool makeVisibleInVisualViewport =
       !document().page()->settings().getInertVisualViewport();
 
   LayoutRect bounds = boundingBox();
   if (centerIfNeeded)
     layoutObject()->scrollRectToVisible(
@@ skipping 159 matching lines @@
     callback->handleEvent(&scrollState);
   if (callback->nativeScrollBehavior() !=
       WebNativeScrollBehavior::DisableNativeScroll)
     nativeApplyScroll(scrollState);
   if (callback->nativeScrollBehavior() ==
       WebNativeScrollBehavior::PerformAfterNativeScroll)
     callback->handleEvent(&scrollState);
 }
 
 int Element::offsetLeft() {
-  document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  ensureCompositingInputsClean();
   if (LayoutBoxModelObject* layoutObject = layoutBoxModelObject())
     return adjustLayoutUnitForAbsoluteZoom(
                LayoutUnit(layoutObject->pixelSnappedOffsetLeft(offsetParent())),
                layoutObject->styleRef())
         .round();
   return 0;
 }
 
 int Element::offsetTop() {
-  document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  ensureCompositingInputsClean();
   if (LayoutBoxModelObject* layoutObject = layoutBoxModelObject())
     return adjustLayoutUnitForAbsoluteZoom(
                LayoutUnit(layoutObject->pixelSnappedOffsetTop(offsetParent())),
                layoutObject->styleRef())
         .round();
   return 0;
 }
 
 int Element::offsetWidth() {
   document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
@@ skipping 454 matching lines @@
   IntSize viewportSize = document().page()->frameHost().visualViewport().size();
   IntRect rect(0, 0, viewportSize.width(), viewportSize.height());
   // We don't use absoluteBoundingBoxRect() because it can return an IntRect
   // larger the actual size by 1px. crbug.com/470503
   rect.intersect(document().view()->contentsToViewport(
       roundedIntRect(layoutObject()->absoluteBoundingBoxFloatRect())));
   return rect;
 }
 
 void Element::clientQuads(Vector<FloatQuad>& quads) {
-  document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  ensureCompositingInputsClean();
 
   LayoutObject* elementLayoutObject = layoutObject();
   if (!elementLayoutObject)
     return;
 
   if (isSVGElement() && !elementLayoutObject->isSVGRoot()) {
     // Get the bounding rectangle from the SVG model.
     if (toSVGElement(this)->isSVGGraphicsElement())
       quads.push_back(elementLayoutObject->localToAbsoluteQuad(
           elementLayoutObject->objectBoundingBox()));
@@ skipping 2979 matching lines @@
   if (!activityLogger)
     return;
   Vector<String, 4> argv;
   argv.push_back(element);
   argv.push_back(params.name.toString());
   argv.push_back(params.oldValue);
   argv.push_back(params.newValue);
   activityLogger->logEvent("blinkSetAttribute", argv.size(), argv.data());
 }
 
+void Element::ensureCompositingInputsClean() {
+  if (!inActiveDocument())
+    return;
+
+  // The call to updateLifecycleToCompositingCleanPlusScrolling| below would
+  // also run layout for us if we omitted this call. However we do not want to
+  // include pending style sheets when doing the layout, hence this call.
+  document().updateStyleAndLayoutIgnorePendingStylesheets();

[chrishtr, 2017/01/25 21:36:28]

Previously it was updateStyleAndLayoutIgnorePendingStylesheetsForNode(this)
instead.
Why the change?

[smcgruer, 2017/01/25 21:39:05]

All updateStyleAndLayoutIgnorePendingStylesheetsForNode(node) does is early-exit
on !node->inActiveDocument(), and then call
updateStyleAndLayoutIgnorePendingStylesheets(). I already do the early-exit
check above, so it seemed superfluous, but I can change it back if you'd prefer.

[chrishtr, 2017/01/25 22:18:56]

Oh ok.

+
+  if (FrameView* view = document().view())
+    view->updateLifecycleToCompositingCleanPlusScrolling();
+}
+
 DEFINE_TRACE(Element) {
   if (hasRareData())
     visitor->trace(elementRareData());
   visitor->trace(m_elementData);
   ContainerNode::trace(visitor);
 }
 
 DEFINE_TRACE_WRAPPERS(Element) {
   if (hasRareData()) {
     visitor->traceWrappers(elementRareData());
   }
   ContainerNode::traceWrappers(visitor);
 }
 
 }  // namespace blink