Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 2647533002: Force compositing inputs to be clean for getBoundingClientRect (Closed)
Patch Set: Partial response to reviewer comments, uploading for feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved. 6 * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 783 matching lines...) Expand 10 before | Expand all | Expand 10 after
794 void classAttributeChanged(const AtomicString& newClassString); 794 void classAttributeChanged(const AtomicString& newClassString);
795 795
796 static bool attributeValueIsJavaScriptURL(const Attribute&); 796 static bool attributeValueIsJavaScriptURL(const Attribute&);
797 797
798 PassRefPtr<ComputedStyle> originalStyleForLayoutObject(); 798 PassRefPtr<ComputedStyle> originalStyleForLayoutObject();
799 799
800 Node* insertAdjacent(const String& where, Node* newChild, ExceptionState&); 800 Node* insertAdjacent(const String& where, Node* newChild, ExceptionState&);
801 801
802 virtual void parserDidSetAttributes() {} 802 virtual void parserDidSetAttributes() {}
803 803
804 // Helper method which ensures that compositing inputs have been cleaned.
805 // Cleaning the compositing inputs is required when computing the location of
806 // position:sticky elements or their descendants.
807 void ensureCompositingInputsClean();
808
804 private: 809 private:
805 void scrollLayoutBoxBy(const ScrollToOptions&); 810 void scrollLayoutBoxBy(const ScrollToOptions&);
806 void scrollLayoutBoxTo(const ScrollToOptions&); 811 void scrollLayoutBoxTo(const ScrollToOptions&);
807 void scrollFrameBy(const ScrollToOptions&); 812 void scrollFrameBy(const ScrollToOptions&);
808 void scrollFrameTo(const ScrollToOptions&); 813 void scrollFrameTo(const ScrollToOptions&);
809 814
810 bool hasElementFlag(ElementFlags mask) const { 815 bool hasElementFlag(ElementFlags mask) const {
811 return hasRareData() && hasElementFlagInternal(mask); 816 return hasRareData() && hasElementFlagInternal(mask);
812 } 817 }
813 void setElementFlag(ElementFlags, bool value = true); 818 void setElementFlag(ElementFlags, bool value = true);
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
1191 #define DECLARE_ELEMENT_FACTORY_WITH_TAGNAME(T) \ 1196 #define DECLARE_ELEMENT_FACTORY_WITH_TAGNAME(T) \
1192 static T* create(const QualifiedName&, Document&) 1197 static T* create(const QualifiedName&, Document&)
1193 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \ 1198 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \
1194 T* T::create(const QualifiedName& tagName, Document& document) { \ 1199 T* T::create(const QualifiedName& tagName, Document& document) { \
1195 return new T(tagName, document); \ 1200 return new T(tagName, document); \
1196 } 1201 }
1197 1202
1198 } // namespace blink 1203 } // namespace blink
1199 1204
1200 #endif // Element_h 1205 #endif // Element_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698