Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: src/code-stubs.h

Issue 2647493002: [ic] Clean up handler boilerplate (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 62203c37a7543db7c12cb78e02baf4858da69939..070fc60edc89738b8016d92bdc4542ee9a7ef857 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -102,13 +102,11 @@ class Node;
V(NumberToString) \
V(StringAdd) \
V(GetProperty) \
- V(LoadICProtoArray) \
V(StoreFastElement) \
V(StoreGlobal) \
V(StoreInterceptor) \
V(LoadApiGetter) \
V(LoadIndexedInterceptor) \
- V(LoadField) \
V(GrowArrayElements)
// List of code stubs only used on ARM 32 bits platforms.
@@ -979,36 +977,6 @@ class LoadIndexedStringStub : public PlatformCodeStub {
DEFINE_PLATFORM_CODE_STUB(LoadIndexedString, PlatformCodeStub);
};
-
-class HandlerStub : public HydrogenCodeStub {
- public:
- Code::Kind GetCodeKind() const override { return Code::HANDLER; }
- ExtraICState GetExtraICState() const override { return kind(); }
-
- void InitializeDescriptor(CodeStubDescriptor* descriptor) override;
-
- CallInterfaceDescriptor GetCallInterfaceDescriptor() const override;
-
- protected:
- explicit HandlerStub(Isolate* isolate) : HydrogenCodeStub(isolate) {}
-
- virtual Code::Kind kind() const = 0;
-
- DEFINE_CODE_STUB_BASE(HandlerStub, HydrogenCodeStub);
-};
-
-class LoadFieldStub : public TurboFanCodeStub {
- public:
- explicit LoadFieldStub(Isolate* isolate) : TurboFanCodeStub(isolate) {}
-
- Code::Kind GetCodeKind() const override { return Code::HANDLER; }
- ExtraICState GetExtraICState() const override { return GetCodeKind(); }
-
- private:
- DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadField);
- DEFINE_TURBOFAN_CODE_STUB(LoadField, TurboFanCodeStub);
-};
-
class KeyedLoadSloppyArgumentsStub : public TurboFanCodeStub {
public:
explicit KeyedLoadSloppyArgumentsStub(Isolate* isolate)
@@ -1649,30 +1617,6 @@ class CallICTrampolineStub : public PlatformCodeStub {
DEFINE_PLATFORM_CODE_STUB(CallICTrampoline, PlatformCodeStub);
};
-class LoadICProtoArrayStub : public TurboFanCodeStub {
- public:
- explicit LoadICProtoArrayStub(Isolate* isolate,
- bool throw_reference_error_if_nonexistent)
- : TurboFanCodeStub(isolate) {
- minor_key_ = ThrowReferenceErrorIfNonexistentBits::encode(
- throw_reference_error_if_nonexistent);
- }
-
- bool throw_reference_error_if_nonexistent() const {
- return ThrowReferenceErrorIfNonexistentBits::decode(minor_key_);
- }
-
- ExtraICState GetExtraICState() const final {
- return static_cast<ExtraICState>(minor_key_);
- }
-
- private:
- class ThrowReferenceErrorIfNonexistentBits : public BitField<bool, 0, 1> {};
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadICProtoArray);
- DEFINE_TURBOFAN_CODE_STUB(LoadICProtoArray, TurboFanCodeStub);
-};
-
class DoubleToIStub : public PlatformCodeStub {
public:
DoubleToIStub(Isolate* isolate, Register source, Register destination,
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698