Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: src/code-stubs.cc

Issue 2647493002: [ic] Clean up handler boilerplate (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.h ('k') | src/ic/accessor-assembler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index 5f2e5b727486984291e6cc11f9d69c7103333e14..993b06d4ecae915825f7a669ff8440e5c6a01942 100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -12,8 +12,6 @@
#include "src/code-stub-assembler.h"
#include "src/factory.h"
#include "src/gdb-jit.h"
-#include "src/ic/accessor-assembler.h"
-#include "src/ic/handler-compiler.h"
#include "src/ic/ic-stats.h"
#include "src/ic/ic.h"
#include "src/macro-assembler.h"
@@ -439,11 +437,6 @@ Handle<Code> TurboFanCodeStub::GenerateCode() {
return compiler::CodeAssembler::GenerateCode(&state);
}
-void LoadICProtoArrayStub::GenerateAssembly(CodeAssemblerState* state) const {
- AccessorAssembler::GenerateLoadICProtoArray(
- state, throw_reference_error_if_nonexistent());
-}
-
void ElementsTransitionAndStoreStub::GenerateAssembly(
compiler::CodeAssemblerState* state) const {
typedef CodeStubAssembler::Label Label;
@@ -1618,11 +1611,6 @@ void StoreGlobalStub::GenerateAssembly(
}
}
-void LoadFieldStub::GenerateAssembly(
- compiler::CodeAssemblerState* state) const {
- AccessorAssembler::GenerateLoadField(state);
-}
-
void KeyedLoadSloppyArgumentsStub::GenerateAssembly(
compiler::CodeAssemblerState* state) const {
typedef CodeStubAssembler::Label Label;
@@ -1779,25 +1767,6 @@ void JSEntryStub::FinishCode(Handle<Code> code) {
code->set_handler_table(*handler_table);
}
-
-void HandlerStub::InitializeDescriptor(CodeStubDescriptor* descriptor) {
- DCHECK(kind() == Code::LOAD_IC || kind() == Code::KEYED_LOAD_IC);
- if (kind() == Code::KEYED_LOAD_IC) {
- descriptor->Initialize(
- FUNCTION_ADDR(Runtime_KeyedLoadIC_MissFromStubFailure));
- }
-}
-
-
-CallInterfaceDescriptor HandlerStub::GetCallInterfaceDescriptor() const {
- if (kind() == Code::LOAD_IC || kind() == Code::KEYED_LOAD_IC) {
- return LoadWithVectorDescriptor(isolate());
- } else {
- DCHECK(kind() == Code::STORE_IC || kind() == Code::KEYED_STORE_IC);
- return StoreWithVectorDescriptor(isolate());
- }
-}
-
void TransitionElementsKindStub::InitializeDescriptor(
CodeStubDescriptor* descriptor) {
descriptor->Initialize(
« no previous file with comments | « src/code-stubs.h ('k') | src/ic/accessor-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698