Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: src/frames.h

Issue 2647433002: Clarify the order of frame summaries and rename getters (Closed)
Patch Set: Fix bug Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug-scopes.cc ('k') | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index 74131e874be003e4889f89269ec930e8d28d3d6c..62470e3a03028657711af43a253ac22041822d34 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -858,11 +858,10 @@ class FrameSummary BASE_EMBEDDED {
~FrameSummary();
- static inline FrameSummary GetFirst(const StandardFrame* frame) {
- return Get(frame, 0);
- }
- static FrameSummary Get(const StandardFrame* frame, int index);
+ static FrameSummary GetTop(const StandardFrame* frame);
+ static FrameSummary GetBottom(const StandardFrame* frame);
static FrameSummary GetSingle(const StandardFrame* frame);
+ static FrameSummary Get(const StandardFrame* frame, int index);
// Dispatched accessors.
Handle<Object> receiver() const;
@@ -924,6 +923,8 @@ class StandardFrame : public StackFrame {
virtual bool IsConstructor() const;
// Build a list with summaries for this frame including all inlined frames.
+ // The functions are ordered bottom-to-top (i.e. summaries.last() is the
+ // top-most activation; caller comes before callee).
virtual void Summarize(
List<FrameSummary>* frames,
FrameSummary::Mode mode = FrameSummary::kExactSummary) const;
« no previous file with comments | « src/debug/debug-scopes.cc ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698