Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: src/debug/debug.h

Issue 2647433002: Clarify the order of frame summaries and rename getters (Closed)
Patch Set: Fix bug Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_DEBUG_H_ 5 #ifndef V8_DEBUG_DEBUG_H_
6 #define V8_DEBUG_DEBUG_H_ 6 #define V8_DEBUG_DEBUG_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/assembler.h" 10 #include "src/assembler.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 DEBUG_BREAK_SLOT_AT_CALL, 70 DEBUG_BREAK_SLOT_AT_CALL,
71 DEBUG_BREAK_SLOT_AT_RETURN, 71 DEBUG_BREAK_SLOT_AT_RETURN,
72 DEBUG_BREAK_SLOT_AT_TAIL_CALL, 72 DEBUG_BREAK_SLOT_AT_TAIL_CALL,
73 }; 73 };
74 74
75 const int kDebugPromiseNoID = 0; 75 const int kDebugPromiseNoID = 0;
76 const int kDebugPromiseFirstID = 1; 76 const int kDebugPromiseFirstID = 1;
77 77
78 class BreakLocation { 78 class BreakLocation {
79 public: 79 public:
80 static BreakLocation FromFrame(StandardFrame* frame); 80 static BreakLocation FromFrame(Handle<DebugInfo> debug_info,
81 JavaScriptFrame* frame);
81 82
82 static void AllAtCurrentStatement(Handle<DebugInfo> debug_info, 83 static void AllAtCurrentStatement(Handle<DebugInfo> debug_info,
83 JavaScriptFrame* frame, 84 JavaScriptFrame* frame,
84 List<BreakLocation>* result_out); 85 List<BreakLocation>* result_out);
85 86
86 inline bool IsReturn() const { return type_ == DEBUG_BREAK_SLOT_AT_RETURN; } 87 inline bool IsReturn() const { return type_ == DEBUG_BREAK_SLOT_AT_RETURN; }
87 inline bool IsCall() const { return type_ == DEBUG_BREAK_SLOT_AT_CALL; } 88 inline bool IsCall() const { return type_ == DEBUG_BREAK_SLOT_AT_CALL; }
88 inline bool IsTailCall() const { 89 inline bool IsTailCall() const {
89 return type_ == DEBUG_BREAK_SLOT_AT_TAIL_CALL; 90 return type_ == DEBUG_BREAK_SLOT_AT_TAIL_CALL;
90 } 91 }
(...skipping 780 matching lines...) Expand 10 before | Expand all | Expand 10 after
871 Handle<Code> code); 872 Handle<Code> code);
872 static bool DebugBreakSlotIsPatched(Address pc); 873 static bool DebugBreakSlotIsPatched(Address pc);
873 static void ClearDebugBreakSlot(Isolate* isolate, Address pc); 874 static void ClearDebugBreakSlot(Isolate* isolate, Address pc);
874 }; 875 };
875 876
876 877
877 } // namespace internal 878 } // namespace internal
878 } // namespace v8 879 } // namespace v8
879 880
880 #endif // V8_DEBUG_DEBUG_H_ 881 #endif // V8_DEBUG_DEBUG_H_
OLDNEW
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698