Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: media/formats/mp4/box_definitions.h

Issue 264743016: Change H264AnnexBBitstreamConverter to use AVCDecoderConfigurationRecord. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address CR comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/h264_to_annex_b_bitstream_converter_unittest.cc ('k') | media/formats/mp4/box_definitions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/box_definitions.h
diff --git a/media/formats/mp4/box_definitions.h b/media/formats/mp4/box_definitions.h
index 9daa82e136c11e188854f377d741971f0b854ff8..5aa0e493a6c94c700d037a4940661969d7467a31 100644
--- a/media/formats/mp4/box_definitions.h
+++ b/media/formats/mp4/box_definitions.h
@@ -150,6 +150,13 @@ struct MEDIA_EXPORT HandlerReference : Box {
struct MEDIA_EXPORT AVCDecoderConfigurationRecord : Box {
DECLARE_BOX_METHODS(AVCDecoderConfigurationRecord);
+ // Parses AVCDecoderConfigurationRecord data encoded in |data|.
+ // Note: This method is intended to parse data outside the MP4StreamParser
+ // context and therefore the box header is not expected to be present
+ // in |data|.
+ // Returns true if |data| was successfully parsed.
+ bool Parse(const uint8* data, int data_size);
+
uint8 version;
uint8 profile_indication;
uint8 profile_compatibility;
@@ -161,6 +168,9 @@ struct MEDIA_EXPORT AVCDecoderConfigurationRecord : Box {
std::vector<SPS> sps_list;
std::vector<PPS> pps_list;
+
+ private:
+ bool ParseInternal(BufferReader* reader);
};
struct MEDIA_EXPORT PixelAspectRatioBox : Box {
« no previous file with comments | « media/filters/h264_to_annex_b_bitstream_converter_unittest.cc ('k') | media/formats/mp4/box_definitions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698