Change H264AnnexBBitstreamConverter to use AVCDecoderConfigurationRecord.

media/formats/mp4/box_reader.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FORMATS_MP4_BOX_READER_H_
 #define MEDIA_FORMATS_MP4_BOX_READER_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 11 matching lines @@
 
 struct MEDIA_EXPORT Box {
   virtual ~Box();
   virtual bool Parse(BoxReader* reader) = 0;
   virtual FourCC BoxType() const = 0;
 };
 
 class MEDIA_EXPORT BufferReader {
  public:
   BufferReader(const uint8* buf, const int size)
-    : buf_(buf), size_(size), pos_(0) {}
+      : buf_(buf), size_(size), pos_(0) {
+    CHECK(buf);

[scherkus (not reviewing), 2014/05/05 18:22:17]

did you mean to add these?, or are these leftover from development?

[acolwell GONE FROM CHROMIUM, 2014/05/05 18:49:02]

Yes. This is intended to protect release code from invalid data that may have
snuck by our normal defenses. The CHECK(buf) isn't probably a big deal, but a
negative size could be problematic.

+    CHECK_GE(size, 0);
+  }
 
   bool HasBytes(int count) { return (pos() + count <= size()); }
 
   // Read a value from the stream, perfoming endian correction, and advance the
   // stream pointer.
   bool Read1(uint8* v)  WARN_UNUSED_RESULT;
   bool Read2(uint16* v) WARN_UNUSED_RESULT;
   bool Read2s(int16* v) WARN_UNUSED_RESULT;
   bool Read4(uint32* v) WARN_UNUSED_RESULT;
   bool Read4s(int32* v) WARN_UNUSED_RESULT;
@@ skipping 162 matching lines @@
     pos_ += child_reader.size();
   }
 
   return !err;
 }
 
 }  // namespace mp4
 }  // namespace media
 
 #endif  // MEDIA_FORMATS_MP4_BOX_READER_H_