Change H264AnnexBBitstreamConverter to use AVCDecoderConfigurationRecord.

media/formats/mp4/box_definitions.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FORMATS_MP4_BOX_DEFINITIONS_H_
 #define MEDIA_FORMATS_MP4_BOX_DEFINITIONS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 132 matching lines @@
 
 struct MEDIA_EXPORT HandlerReference : Box {
   DECLARE_BOX_METHODS(HandlerReference);
 
   TrackType type;
 };
 
 struct MEDIA_EXPORT AVCDecoderConfigurationRecord : Box {
   DECLARE_BOX_METHODS(AVCDecoderConfigurationRecord);
 
+  bool Parse(const uint8* data, int data_size);

[scherkus (not reviewing), 2014/05/05 18:22:17]

docs / how is this different from the one from DECLARE_BOX_METHODS():

virtual bool Parse(BoxReader* reader) OVERRIDE;


can we have the caller construct a BoxReader instead?

[acolwell GONE FROM CHROMIUM, 2014/05/05 18:49:02]

Done.
No we can't use the BoxReader because the data passed to this function doesn't
actually have the box header. This function allows you to parse the contents of
the box, w/o the need for the box header.

+
   uint8 version;
   uint8 profile_indication;
   uint8 profile_compatibility;
   uint8 avc_level;
   uint8 length_size;
 
   typedef std::vector<uint8> SPS;
   typedef std::vector<uint8> PPS;
 
   std::vector<SPS> sps_list;
   std::vector<PPS> pps_list;
+
+private:

[scherkus (not reviewing), 2014/05/05 18:22:17]

indent one more

[acolwell GONE FROM CHROMIUM, 2014/05/05 18:49:02]

Done.

+  bool ParseInternal(BufferReader* reader);
 };
 
 struct MEDIA_EXPORT PixelAspectRatioBox : Box {
   DECLARE_BOX_METHODS(PixelAspectRatioBox);
 
   uint32 h_spacing;
   uint32 v_spacing;
 };
 
 struct MEDIA_EXPORT VideoSampleEntry : Box {
@@ skipping 199 matching lines @@
   std::vector<TrackFragment> tracks;
   std::vector<ProtectionSystemSpecificHeader> pssh;
 };
 
 #undef DECLARE_BOX
 
 }  // namespace mp4
 }  // namespace media
 
 #endif  // MEDIA_FORMATS_MP4_BOX_DEFINITIONS_H_