Add Widevine signature files into Mac build

chrome/BUILD.gn

Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 6f50b978617dccf1648f8ee6c2f002f1c900a35c..3a95db30cb66f4605e0017b0189a123bf3b63e6c 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -649,6 +649,13 @@ if (is_win) {
       # non-component builds, will ensure the export symbol table is correct.
       ":verify_chrome_framework_order",
     ]
+
+    # Only official builds that include Widevine need the widevine
+    # signature file.
+    if (is_chrome_branded && enable_pepper_cdms) {
+      sources += [ "$root_out_dir/$chrome_framework_name.sig" ]
+      public_deps += [ ":sign_chrome_framework_for_widevine" ]
+    }
   }
 
   action("clean_up_old_versions") {
@@ -862,12 +869,25 @@ if (is_win) {
         ":widevine_cdm_library_copy",
         "//third_party/widevine/cdm:widevinecdmadapter",
       ]
+
+      # Signatures are only generated for official chrome.
+      if (is_chrome_branded) {
+        sources += [
+          "$root_out_dir/$widevine_cdm_path/widevinecdmadapter.plugin.sig",
+          "$root_out_dir/libwidevinecdm.dylib.sig",
+        ]
+        public_deps += [ ":sign_cdm_adapter_for_widevine" ]
+      }
     }
 
     copy("widevine_cdm_library_copy") {
       sources = [
         "$root_out_dir/$widevine_cdm_path/libwidevinecdm.dylib",
       ]
+      if (is_chrome_branded) {
+        sources +=
+            [ "$root_out_dir/$widevine_cdm_path/libwidevinecdm.dylib.sig" ]
+      }
       outputs = [
         "$root_out_dir/{{source_file_part}}",
       ]
@@ -887,6 +907,25 @@ if (is_win) {
         "//third_party/widevine/cdm:widevine_cdm_manifest",
       ]
     }
+
+    widevine_sign_file("sign_cdm_adapter_for_widevine") {
+      file = "$root_out_dir/$widevine_cdm_path/widevinecdmadapter.plugin"
+      deps = [
+        "//third_party/widevine/cdm:widevinecdmadapter",
+      ]
+    }
+
+    widevine_sign_file("sign_chrome_framework_for_widevine") {
+      file = "$root_out_dir/$chrome_framework_name.framework/"
+      if (defined(chrome_framework_version)) {

[Robert Sesek, 2017/02/23 18:09:32]

Can the script that produces the signature file go through symlink at
"$root_out_dir/$chrome_framework_name.framework/$chrome_framework_name" ? 

[jrummell, 2017/02/23 18:39:03]

I tried it, and get the error:
ERROR Input to target not generated by a dependency.
The file:
  //out/Release/Google Chrome Framework.framework/Google Chrome Framework
is listed as an input or source for the target:
  //chrome:sign_chrome_framework_for_widevine
but no targets in the build generate that file.

The outputs for ":chrome_framework" include:
//out/Release/Google Chrome Framework.framework/Versions/A/Google Chrome
Framework

I don't see anything in this file that creates the symlink. Where is that done?

[Robert Sesek, 2017/02/23 18:54:49]

Ah, that makes sense. There's an issue with ninja where it does not properly
stat links (it uses stat instead of lstat), so you cannot actually have a build
edge be a symbolic link. To get around that, those symlinks are actually
generated at gn gen time, since that's the only reliable way to do it.

+        file += "Versions/$chrome_framework_version/"
+      }
+      file += "$chrome_framework_name"
+      signature_file = "$root_out_dir/$chrome_framework_name.sig"
+      deps = [
+        ":chrome_framework",
+      ]
+    }
   }
 
   group("widevine_cdm_library") {