Add Widevine signature files into Mac build

chrome/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/compiler/pgo/pgo.gni")
 import("//build/config/features.gni")
 import("//build/config/locales.gni")
@@ skipping 509 matching lines @@
     sources = [
       "app/chrome_exe_main_mac.c",
     ]
 
     extra_configs = [ "//build/config/compiler:wexit_time_destructors" ]
 
     deps = [
       ":chrome_app_strings_bundle_data",
       ":chrome_resources",
       ":chrome_versioned_bundle_data",
+      ":widevine_add_framework_signature",
       "//build/config/sanitizers:deps",
       "//chrome/common:version_header",
     ]
 
     # Remove the default strip configuration (which strips all symbols) so that
     # a saves file can be specified.
     if (enable_stripping) {
       remove_configs = [ "//build/config/mac:strip_all" ]
 
       ldflags =
@@ skipping 104 matching lines @@
       # bundle via a script that performs additional actions, rather than
       # relying on a bundle_data to copy it.
       ":keystone_registration_framework",
 
       # verify_chrome_framework_order depends on :chrome_framework and, for
       # non-component builds, will ensure the export symbol table is correct.
       ":verify_chrome_framework_order",
     ]
   }
 
+  # On official builds, Widevine needs a signature file for the framework.
+  # Copy this file directly into the final output directory.
+  if (is_chrome_branded && enable_pepper_cdms) {
+    copy("widevine_add_framework_signature") {
+      sources = [
+        "$root_out_dir/$chrome_framework_name.sig",
+      ]
+
+      final_directory = "$root_out_dir/$chrome_product_full_name.app/Contents/Versions/$chrome_version_full/$chrome_framework_name.framework/"

[Robert Sesek, 2017/02/21 16:15:00]

I think this is just re-introducing the issue I raised initially: you cannot
copy the sig file into the framework after it has been packaged. You shouldn't
need to change where the .sig file lives from PS5. The only real difference is
that the input to widevine_sign_file is now a symlink.

[jrummell, 2017/02/21 19:54:56]

I tried that earlier. With "sources += [
"$root_out_dir/$chrome_framework_name.sig" ]", the signature file is copied into
Contents/Versions/58.0.3016.0/Google Chrome Framework.framework" (actual
framework is 2 levels down in Versions/A). My concern was that this didn't
handle different versions, but based on your comment in email, it looks like
this won't be an issue. I'll make that change.

[Robert Sesek, 2017/02/21 22:26:48]

Shouldn't it be copied into Contents/Versions/58.0.3016.0/ to live next to the
.framework?
Because Chrome externally versions its frameworks
(Chrome.app/Contents/Versions/X), there will definitely only ever be one version
in the Google Chrome Framework.framework per outer version directory.

[jrummell, 2017/02/22 01:02:08]

Yes. I had the directories all expanded in the Finder view and didn't match the
indentation properly.
Good to know. Added comment in the code.

+      if (defined(chrome_framework_version)) {
+        final_directory += "Versions/$chrome_framework_version/"
+      }
+      outputs = [
+        "$final_directory/{{source_file_part}}",
+      ]
+
+      deps = [
+        ":chrome_versioned_bundle_data",
+        ":sign_chrome_framework_for_widevine",
+      ]
+    }
+  } else {
+    group("widevine_add_framework_signature") {
+    }
+  }
+
   action("clean_up_old_versions") {
     script = "//chrome/tools/build/mac/clean_up_old_versions.py"
     outputs = [
       "$root_gen_dir/run_$target_name.stamp",
     ]
     args = [
              rebase_path("$root_out_dir/$chrome_product_full_name.app",
                          root_build_dir),
              "$chrome_version_full",
            ] + rebase_path(outputs, root_build_dir)
@@ skipping 191 matching lines @@
         "{{bundle_root_dir}}/Libraries/$widevine_cdm_path/{{source_file_part}}",
       ]
       public_deps = [
         # Need this intermediate dependency because "widevinecdm" is a
         # shared_library if !is_chrome_branded, and then depending on
         # "widevinecdm" directly would cause it to be linked into the Chromium
         # Framework, which we don't want.
         ":widevine_cdm_library_copy",
         "//third_party/widevine/cdm:widevinecdmadapter",
       ]
+
+      # Signatures are only generated for official chrome.
+      if (is_chrome_branded) {
+        sources += [
+          "$root_out_dir/$widevine_cdm_path/widevinecdmadapter.plugin.sig",
+          "$root_out_dir/libwidevinecdm.dylib.sig",
+        ]
+        public_deps += [ ":sign_cdm_adapter_for_widevine" ]
+      }
     }
 
     copy("widevine_cdm_library_copy") {
       sources = [
         "$root_out_dir/$widevine_cdm_path/libwidevinecdm.dylib",
       ]
+      if (is_chrome_branded) {
+        sources +=
+            [ "$root_out_dir/$widevine_cdm_path/libwidevinecdm.dylib.sig" ]
+      }
       outputs = [
         "$root_out_dir/{{source_file_part}}",
       ]
       deps = [
         "//third_party/widevine/cdm:widevinecdm",
       ]
     }
 
     bundle_data("widevine_cdm_library_manifest") {
       sources = [
         "$root_out_dir/WidevineCdm/manifest.json",
       ]
       outputs = [
         "{{bundle_root_dir}}/Libraries/WidevineCdm/{{source_file_part}}",
       ]
       public_deps = [
         "//third_party/widevine/cdm:widevine_cdm_manifest",
       ]
     }
+
+    widevine_sign_file("sign_cdm_adapter_for_widevine") {
+      file = "$root_out_dir/$widevine_cdm_path/widevinecdmadapter.plugin"
+      deps = [
+        "//third_party/widevine/cdm:widevinecdmadapter",
+      ]
+    }
+
+    widevine_sign_file("sign_chrome_framework_for_widevine") {
+      file = "$root_out_dir/$chrome_framework_name.framework/"
+      if (defined(chrome_framework_version)) {
+        file += "Versions/$chrome_framework_version/"
+      }
+      file += "$chrome_framework_name"
+      signature_file = "$root_out_dir/$chrome_framework_name.sig"
+      deps = [
+        ":chrome_framework",
+      ]
+    }
   }
 
   group("widevine_cdm_library") {
     if (_should_bundle_widevine) {
       deps = [
         ":widevine_cdm_library_binaries",
         ":widevine_cdm_library_manifest",
       ]
     }
   }
@@ skipping 707 matching lines @@
       "//chrome/app/theme/$branding_path_component/product_logo_48.png",
       "//chrome/tools/build/linux/chrome-wrapper",
       "//third_party/xdg-utils/scripts/xdg-mime",
       "//third_party/xdg-utils/scripts/xdg-settings",
     ]
     outputs = [
       "$root_out_dir/{{source_file_part}}",
     ]
   }
 }