Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3065)

Unified Diff: chrome/browser/chrome_browser_field_trials.cc

Issue 2647353003: Make LocalMemory (aka InMemory) the default for persistent histograms. (Closed)
Patch Set: make LocalMemory be the default for now Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_field_trials.cc
diff --git a/chrome/browser/chrome_browser_field_trials.cc b/chrome/browser/chrome_browser_field_trials.cc
index 69fac07e38c02d44ee3bab2be872a35d54c4a30a..e68926d578093d26d6a76fc8b263fc6616b2d772 100644
--- a/chrome/browser/chrome_browser_field_trials.cc
+++ b/chrome/browser/chrome_browser_field_trials.cc
@@ -73,6 +73,7 @@ void InstantiatePersistentHistograms() {
const uint32_t kAllocId = 0x935DDD43; // SHA1(BrowserMetrics)
std::string storage = variations::GetVariationParamValueByFeature(
base::kPersistentHistogramsFeature, "storage");
+
if (storage == "MappedFile") {
// If for some reason the existing "active" file could not be moved above
// then it is essential it be scheduled for deletion when possible and the
@@ -98,7 +99,7 @@ void InstantiatePersistentHistograms() {
result = MAPPED_FILE_FAILED;
}
}
- } else if (storage == "LocalMemory") {
+ } else if (storage.empty() || storage == "LocalMemory") {
// Use local memory for storage even though it will not persist across
// an unclean shutdown.
base::GlobalHistogramAllocator::CreateWithLocalMemory(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698