Update dart2js unit tests to dart_parser and dart_scanner.

Update dart2js unit tests to dart_parser and dart_scanner.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/f09bf74cbeff251062e061bd2883eb2a06c755d7

[ahe, 2017-01-24 15:14:36]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[ahe, 2017-01-24 15:14:37]

The code in dart2js_incremental was rather broken, and I don't understand how
the tests could have been passing. Regardless, dartino is no more, so I think
it's safe to delete it.

Not all unit tests are passing yet. Keep tuned to this channel for the exciting
conclusion in a follow-up CL.

[Siggi Cherem (dart-lang), 2017-01-24 21:27:38]

lgtm. Thanks Peter!

Yeah, maybe the dart2js_incremental were marked as failing in .status files for
a long time? It is anyways good to delete it now. We can also remove logic
related to `forgetElement` if that helps in our process of porting dart2js to
kernel.

https://codereview.chromium.org/2647343003/diff/1/tests/compiler/dart2js/diag...
File tests/compiler/dart2js/diagnostic_reporter_helper.dart (right):

https://codereview.chromium.org/2647343003/diff/1/tests/compiler/dart2js/diag...
tests/compiler/dart2js/diagnostic_reporter_helper.dart:13: import
'package:dart_scanner/dart_scanner.dart';
nit: sort imports

[ahe, 2017-01-25 07:46:37]

Thank you, Siggi!

https://codereview.chromium.org/2647343003/diff/1/tests/compiler/dart2js/diag...
File tests/compiler/dart2js/diagnostic_reporter_helper.dart (right):

https://codereview.chromium.org/2647343003/diff/1/tests/compiler/dart2js/diag...
tests/compiler/dart2js/diagnostic_reporter_helper.dart:13: import
'package:dart_scanner/dart_scanner.dart';
On 2017/01/24 21:27:38, Siggi Cherem (dart-lang) wrote:
> nit: sort imports

Done (assuming dart, package, local, then alphabetically).

[ahe, 2017-01-25 07:46:54]

Description was changed from

==========
Update dart2js unit tests to dart_parser and dart_scanner.
==========

to

==========
Update dart2js unit tests to dart_parser and dart_scanner.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f09bf74cbeff251062e061bd2883eb2a06c755d7
==========

[ahe, 2017-01-25 07:46:55]

Committed patchset #2 (id:20001) manually as
f09bf74cbeff251062e061bd2883eb2a06c755d7 (presubmit successful).

[ahe, 2017-01-25 07:49:54]

On 2017/01/24 21:27:38, Siggi Cherem (dart-lang) wrote:
> Yeah, maybe the dart2js_incremental were marked as failing in .status files
for
> a long time? It is anyways good to delete it now. We can also remove logic
> related to `forgetElement` if that helps in our process of porting dart2js to
> kernel.

I didn't find any status file entries for incremental. We can remove
forgetElement, but I'd leave that to you guys as I don't foresee a need to touch
the elements in dart2js.