Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chromecast/net/connectivity_checker_impl.h

Issue 2647323010: [Chromecast] Add proxy server support to chromecast (Closed)
Patch Set: Fix unittest failure Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/net/connectivity_checker_impl.h
diff --git a/chromecast/net/connectivity_checker_impl.h b/chromecast/net/connectivity_checker_impl.h
index 8779d0cc6bf92fff149f247df4f69b1491a49e72..f3b27a47ff51d678bc05aad96fffe233052ec64f 100644
--- a/chromecast/net/connectivity_checker_impl.h
+++ b/chromecast/net/connectivity_checker_impl.h
@@ -12,6 +12,7 @@
#include "net/url_request/url_request.h"
class GURL;
+class PrefProxyConfigTracker;
namespace base {
class SingleThreadTaskRunner;
@@ -34,11 +35,13 @@ class ConnectivityCheckerImpl
public:
// Connectivity checking and initialization will run on task_runner.
explicit ConnectivityCheckerImpl(
- const scoped_refptr<base::SingleThreadTaskRunner>& task_runner);
+ const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
+ std::unique_ptr<PrefProxyConfigTracker> pref_proxy_config_tracker);
// ConnectivityChecker implementation:
bool Connected() const override;
void Check() override;
+ void DetachFromPrefService() override;
wzhong 2017/02/07 15:56:03 Can you add a Getter pref_proxy_config_tracker() s
almasrymina 2017/02/08 00:48:04 Removed with new approach.
protected:
~ConnectivityCheckerImpl() override;
@@ -99,6 +102,9 @@ class ConnectivityCheckerImpl
// called.
base::CancelableCallback<void()> timeout_;
+ std::unique_ptr<net::ProxyConfigService> proxy_config_service_;
+ std::unique_ptr<PrefProxyConfigTracker> pref_proxy_config_tracker_;
+
DISALLOW_COPY_AND_ASSIGN(ConnectivityCheckerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698