Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: components/safe_browsing_db/v4_update_protocol_manager_unittest.cc

Issue 2647323009: Add extended reporting level in the update request (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_update_protocol_manager_unittest.cc
diff --git a/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc b/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc
index cdef738250148be8752905ffb7b58efadb71a405..1ca9d84df44558c054f821f916eb693c9f74e338 100644
--- a/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc
+++ b/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc
@@ -58,13 +58,20 @@ class V4UpdateProtocolManagerTest : public PlatformTest {
}
}
+ ExtendedReportingLevel GetExtendedReportingLevel(ExtendedReportingLevel erl) {
+ return erl;
+ }
+
std::unique_ptr<V4UpdateProtocolManager> CreateProtocolManager(
const std::vector<ListUpdateResponse>& expected_lurs,
- bool disable_auto_update = false) {
+ bool disable_auto_update = false,
+ ExtendedReportingLevel erl = SBER_LEVEL_OFF) {
return V4UpdateProtocolManager::Create(
NULL, GetTestV4ProtocolConfig(disable_auto_update),
base::Bind(&V4UpdateProtocolManagerTest::ValidateGetUpdatesResults,
- base::Unretained(this), expected_lurs));
+ base::Unretained(this), expected_lurs),
+ base::Bind(&V4UpdateProtocolManagerTest::GetExtendedReportingLevel,
+ base::Unretained(this), erl));
}
void SetupStoreStates() {
@@ -291,7 +298,7 @@ TEST_F(V4UpdateProtocolManagerTest, TestBase64EncodingUsesUrlEncoding) {
std::string encoded_request_with_minus =
pm->GetBase64SerializedUpdateRequestProto();
- EXPECT_EQ("Cg8KCHVuaXR0ZXN0EgMxLjAaGAgBEAIaCmg4eGZZcVk-OlIiBCABIAIoAQ==",
+ EXPECT_EQ("Cg8KCHVuaXR0ZXN0EgMxLjAaGAgBEAIaCmg4eGZZcVk-OlIiBCABIAIoASICCAE=",
encoded_request_with_minus);
// TODO(vakh): Add a similar test for underscore for completeness, although

Powered by Google App Engine
This is Rietveld 408576698