Reland c9e1b88 and 56726fc with a DDC fix.

Reland c9e1b88 and 56726fc with a DDC fix.


Revert "Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider.""

This reverts commit b701ad64530b500dc6e638cd4b9be716499f6a10.

R=brianwilkerson@google.com, vsm@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b206c84210600f13d7230fd0213777828f6efa73

[Brian Wilkerson, 2017-01-24 15:59:10]

lgtm

[vsm, 2017-01-24 16:41:41]

lgtm with comment

https://codereview.chromium.org/2647323006/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2647323006/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/compiler.dart:90: var sdkSummaryBundle =
sdk.getLinkedBundle();
This logic really needs to be folded in with the redundant bits in analyzer_cli
driver.  Is this not possible?

[scheglov, 2017-01-24 17:04:33]

https://codereview.chromium.org/2647323006/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2647323006/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/compiler.dart:90: var sdkSummaryBundle =
sdk.getLinkedBundle();
On 2017/01/24 16:41:41, vsm wrote:
> This logic really needs to be folded in with the redundant bits in
analyzer_cli
> driver.  Is this not possible?

It is possible.
But it does not seem very useful.

[vsm, 2017-01-24 17:10:36]

https://codereview.chromium.org/2647323006/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2647323006/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/compiler.dart:90: var sdkSummaryBundle =
sdk.getLinkedBundle();
On 2017/01/24 17:04:33, scheglov wrote:
> On 2017/01/24 16:41:41, vsm wrote:
> > This logic really needs to be folded in with the redundant bits in
> analyzer_cli
> > driver.  Is this not possible?
> 
> It is possible.
> But it does not seem very useful.

The current state means bugs like this need to be fixed in multiple places.

In general, from a pure abstraction perspective, almost none of the code in this
function belongs in dev_compiler.

[scheglov, 2017-01-24 17:13:07]

https://codereview.chromium.org/2647323006/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2647323006/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/compiler.dart:90: var sdkSummaryBundle =
sdk.getLinkedBundle();
On 2017/01/24 17:10:35, vsm wrote:
> On 2017/01/24 17:04:33, scheglov wrote:
> > On 2017/01/24 16:41:41, vsm wrote:
> > > This logic really needs to be folded in with the redundant bits in
> > analyzer_cli
> > > driver.  Is this not possible?
> > 
> > It is possible.
> > But it does not seem very useful.
> 
> The current state means bugs like this need to be fixed in multiple places.
> 
> In general, from a pure abstraction perspective, almost none of the code in
this
> function belongs in dev_compiler.
> 

Exactly.
This code duplication should be solved for the whole function, not only for
these two tweaks.
But that's outside of the scope of this CL.

[scheglov, 2017-01-24 17:13:32]

Description was changed from

==========
Reland c9e1b88 and 56726fc with a DDC fix.


Revert "Revert "Use single InputPackagesResultProvider, without
SdkSummaryResultProvider.""

This reverts commit b701ad64530b500dc6e638cd4b9be716499f6a10.

R=brianwilkerson@google.com, vsm@google.com
BUG=
==========

to

==========
Reland c9e1b88 and 56726fc with a DDC fix.


Revert "Revert "Use single InputPackagesResultProvider, without
SdkSummaryResultProvider.""

This reverts commit b701ad64530b500dc6e638cd4b9be716499f6a10.

R=brianwilkerson@google.com, vsm@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b206c84210600f13d7230fd0213777828f6efa73
==========

[scheglov, 2017-01-24 17:13:33]

Committed patchset #1 (id:1) manually as
b206c84210600f13d7230fd0213777828f6efa73 (presubmit successful).