chrome/browser/download/chrome_download_manager_delegate.cc - Issue 2647323004: Move download attribution right after CheckDownloadUrl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.cc

Issue 2647323004: Move download attribution right after CheckDownloadUrl (Closed)

Patch Set: threading refine comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/chrome_download_manager_delegate.cc

diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc

index 3c53d58034b8aee1b05c3813b8d6dcad414f3e63..ed4157b47e5b02e224b4cfc51ddd8dd01c350957 100644

--- a/chrome/browser/download/chrome_download_manager_delegate.cc

+++ b/chrome/browser/download/chrome_download_manager_delegate.cc

@@ -662,7 +662,7 @@ void ChromeDownloadManagerDelegate::CheckDownloadUrl(

service->IsSupportedDownload(*download, suggested_path);

DVLOG(2) << __func__ << "() Start SB URL check for download = "

<< download->DebugString(false);

- service->CheckDownloadUrl(*download,

+ service->CheckDownloadUrl(download,

base::Bind(&CheckDownloadUrlDone,

callback,

is_content_check_supported));