Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2647293007: Move driver creation into ContextBuilder (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -19 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +6 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 5 chunks +62 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 11 months ago (2017-01-24 22:12:40 UTC) #2
scheglov
LGTM
3 years, 11 months ago (2017-01-24 22:14:53 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as c25bd9403f9ccbfe11f1545e924ac832c14d050f (presubmit successful).
3 years, 11 months ago (2017-01-24 22:43:44 UTC) #5
danrubel
3 years, 11 months ago (2017-01-25 14:41:15 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698