Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2647283006: Removing HandleVisible enum from FrameSelection (Closed)
Patch Set: Fixing nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index b798e6497b6c6ec9635e814ffef0eaf72d7b1754..f3ad2d2b9358b9f113fa23f3e04cf77edbcdacd0 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -691,14 +691,10 @@ void SelectionController::setNonDirectionalSelectionIfNeeded(
selection().isHandleVisible() == isHandleVisible)
return;
- const FrameSelection::SetSelectionOptions options =
- isHandleVisible
- ? FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle |
- FrameSelection::HandleVisible
- : FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle;
-
- selection().setSelection(newSelection, options, CursorAlignOnScroll::IfNeeded,
- granularity);
+ selection().setSelection(
+ newSelection, handleVisibility,
+ FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle,
+ CursorAlignOnScroll::IfNeeded, granularity);
}
void SelectionController::setCaretAtHitTestResult(
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698