Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2647283006: Removing HandleVisible enum from FrameSelection (Closed)
Patch Set: Fixing nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameSelection.h
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h
index 0ff79f1a61b23a17695589cfb12ca4cb2d7a25c8..09acee1ba30e0fe277a15ad180c72151216e6f79 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.h
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h
@@ -90,7 +90,6 @@ class CORE_EXPORT FrameSelection final
DoNotUpdateAppearance = 1 << 4,
DoNotClearStrategy = 1 << 5,
DoNotAdjustInFlatTree = 1 << 6,
- HandleVisible = 1 << 7,
};
// Union of values in SetSelectionOption and EUserTriggered
typedef unsigned SetSelectionOptions;
@@ -137,15 +136,19 @@ class CORE_EXPORT FrameSelection final
// TODO(yosin): We should use |SelectionInDOMTree| version instead of
// |VisibleSelection| version.
void setSelection(const VisibleSelection&,
+ HandleVisibility = HandleVisibility::NotVisible,
SetSelectionOptions = CloseTyping | ClearTypingStyle,
CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
TextGranularity = CharacterGranularity);
+ void setSelection(const VisibleSelection&, SetSelectionOptions);
// TODO(yosin): We should use |SelectionInFlatTree| version instead of
// |VisibleSelectionInFlatTree| version.
void setSelection(const VisibleSelectionInFlatTree&,
+ HandleVisibility = HandleVisibility::NotVisible,
SetSelectionOptions = CloseTyping | ClearTypingStyle,
CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
TextGranularity = CharacterGranularity);
+ void setSelection(const VisibleSelectionInFlatTree&, SetSelectionOptions);
bool setSelectedRange(
const EphemeralRange&,
TextAffinity,
@@ -297,6 +300,7 @@ class CORE_EXPORT FrameSelection final
template <typename Strategy>
void setSelectionAlgorithm(const VisibleSelectionTemplate<Strategy>&,
+ HandleVisibility,
SetSelectionOptions,
CursorAlignOnScroll,
TextGranularity);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698