Reintroducing MallocHooks changes with fix for hooks being called when in execvpe after a fork whil…

Reintroducing MallocHooks changes with fix for hooks being called when in execvpe after a fork while the MallocHooks lock is held by a thread that may no longer exist.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/f679b3c3e53bac92df6136eceb56a5febe576819

[bkonyi, 2017-01-23 21:55:54]

bkonyi@google.com changed reviewers:
+ zra@google.com

[bkonyi, 2017-01-23 21:55:55]

https://codereview.chromium.org/2647283004/diff/1/runtime/vm/malloc_hooks.cc
File runtime/vm/malloc_hooks.cc (right):

https://codereview.chromium.org/2647283004/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:167: static const intptr_t INVALID_PID = -1;
I have a feeling this might not be the right style for defining a constant
default value. Let me know if it's not.

[zra, 2017-01-23 22:09:43]

https://codereview.chromium.org/2647283004/diff/1/runtime/vm/malloc_hooks.cc
File runtime/vm/malloc_hooks.cc (right):

https://codereview.chromium.org/2647283004/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:118: ASSERT(original_pid_ != -1);
Use kInvalidPid

https://codereview.chromium.org/2647283004/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:167: static const intptr_t INVALID_PID = -1;
On 2017/01/23 21:55:55, bkonyi wrote:
> I have a feeling this might not be the right style for defining a constant
> default value. Let me know if it's not.

This is fine, but rename to kInvalidPid.

[bkonyi, 2017-01-23 22:12:48]

https://codereview.chromium.org/2647283004/diff/1/runtime/vm/malloc_hooks.cc
File runtime/vm/malloc_hooks.cc (right):

https://codereview.chromium.org/2647283004/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:118: ASSERT(original_pid_ != -1);
On 2017/01/23 22:09:43, zra wrote:
> Use kInvalidPid

Done.

https://codereview.chromium.org/2647283004/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:167: static const intptr_t INVALID_PID = -1;
On 2017/01/23 22:09:43, zra wrote:
> On 2017/01/23 21:55:55, bkonyi wrote:
> > I have a feeling this might not be the right style for defining a constant
> > default value. Let me know if it's not.
> 
> This is fine, but rename to kInvalidPid.

Done.

[zra, 2017-01-23 22:15:25]

lgtm, but let's wait to land until after the last full push for 1.22, which
should happen later today or tomorrow.

[bkonyi, 2017-01-23 22:19:41]

On 2017/01/23 22:15:25, zra wrote:
> lgtm, but let's wait to land until after the last full push for 1.22, which
> should happen later today or tomorrow.

Sounds good. I'm in sessions the rest of the day so it wouldn't make sense to
submit now either way.

[zra, 2017-01-23 23:16:14]

Oh, BTW, make sure to upload your new changes before sending out the "Done"
messages. Thanks!

[bkonyi, 2017-01-30 17:55:28]

Description was changed from

==========
Reintroducing MallocHooks changes with fix for hooks being called when in
execvpe after a fork while the MallocHooks lock is held by a thread that may no
longer exist.

BUG=
==========

to

==========
Reintroducing MallocHooks changes with fix for hooks being called when in
execvpe after a fork while the MallocHooks lock is held by a thread that may no
longer exist.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f679b3c3e53bac92df6136eceb56a5febe576819
==========

[bkonyi, 2017-01-30 17:55:29]

Committed patchset #2 (id:20001) manually as
f679b3c3e53bac92df6136eceb56a5febe576819 (presubmit successful).