LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt - Issue 26472003: Fix improper scrollTop/Left usage in LayoutTests/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt

Issue 26472003: Fix improper scrollTop/Left usage in LayoutTests/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@issue_304768

Patch Set: Fix improper scrollTop/Left usage in LayoutTests/ Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/Element/resources/scrollable-iframe-strict.html ('K') | « LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes.html ('k') | LayoutTests/fast/dom/resources/check-scroll-position-onload.html » ('j') | LayoutTests/fast/dom/resources/check-scroll-position-onload.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt

diff --git a/LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt b/LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt

index 03194f1976ff7e19a7af570dab1e1b2e8758be63..713e69fc773c0d6e9ad7db129683643998a2b23e 100644

--- a/LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt

+++ b/LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt

@@ -5,8 +5,8 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE

PASS iframeStrict.contentDocument.documentElement.scrollTop is 5000

PASS iframeStrict.contentDocument.documentElement.scrollLeft is 4000

-PASS iframeStrict.contentDocument.body.scrollTop is 0

-PASS iframeStrict.contentDocument.body.scrollLeft is 0

+PASS iframeStrict.contentDocument.body.scrollTop is 5000

+PASS iframeStrict.contentDocument.body.scrollLeft is 4000

Dan Beam 2013/10/08 19:25:30 ^ so wait, why are these not 0 here?

tonikitoo_ 2013/10/08 19:52:32 Because we restore the old behavior of document.bo

tonikitoo_ 2013/10/08 20:17:43 Ok, for the purpose of this patch, you are right.

PASS iframeStrict.contentWindow.pageYOffset is 5000

PASS iframeStrict.contentWindow.pageXOffset is 4000

PASS iframeQuirks.contentDocument.documentElement.scrollTop is 0