Fix improper scrollTop/Left usage in LayoutTests/

Fix improper scrollTop/Left usage in LayoutTests/

Rule of thumb here is: if in strict mode, documentElement element
should be used to operate over scrollTop/Left properties.
When in quirks mode, use 'body' element.

CL fixes many layout tests caught by an UseCount/Console warning
being added by https://codereview.chromium.org/26489005/ that
were abusing the relaxed body.scrollTop/Left support Blink currently has.

The exception is LayoutTests/jquery/offset.html, where jQuery on purpose
uses both documentElement and body elements, for cross engine support.

R=Julien Chaffraix, Dan Beam

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159195

[Dan Beam, 2013-10-08 19:25:30]

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/Eleme...
File LayoutTests/fast/dom/Element/resources/scrollable-iframe-strict.html
(left):

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/Eleme...
LayoutTests/fast/dom/Element/resources/scrollable-iframe-strict.html:18:
document.body.scrollLeft = 1;
^ i would maybe leave these here and make an exception

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/Eleme...
File
LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt
(right):

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/Eleme...
LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt:9:
PASS iframeStrict.contentDocument.body.scrollLeft is 4000
^ so wait, why are these not 0 here?

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/resou...
File LayoutTests/fast/dom/resources/check-scroll-position-onload.html (right):

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/resou...
LayoutTests/fast/dom/resources/check-scroll-position-onload.html:10:
result.innerHTML = (document.document.scrollTop == 0) ? "PASS" : "FAIL";
documentElement?

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/events/to...
File LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body.html
(right):

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/events/to...
LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body.html:67: var
scrolledElement = 'document.documentElement'
nit: ; at end, also where is this used?

[tonikitoo_, 2013-10-08 19:52:32]

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/Eleme...
File LayoutTests/fast/dom/Element/resources/scrollable-iframe-strict.html
(left):

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/Eleme...
LayoutTests/fast/dom/Element/resources/scrollable-iframe-strict.html:18:
document.body.scrollLeft = 1;
On 2013/10/08 19:25:30, Dan Beam wrote:
> ^ i would maybe leave these here and make an exception

Good idea.

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/Eleme...
File
LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt
(right):

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/Eleme...
LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt:9:
PASS iframeStrict.contentDocument.body.scrollLeft is 4000
On 2013/10/08 19:25:30, Dan Beam wrote:
> ^ so wait, why are these not 0 here?

Because we restore the old behavior of document.body: it works for both strict
and quirks modes just like before.

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/resou...
File LayoutTests/fast/dom/resources/check-scroll-position-onload.html (right):

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/resou...
LayoutTests/fast/dom/resources/check-scroll-position-onload.html:10:
result.innerHTML = (document.document.scrollTop == 0) ? "PASS" : "FAIL";
On 2013/10/08 19:25:30, Dan Beam wrote:
> documentElement?

nice catch!

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/events/to...
File LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body.html
(right):

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/events/to...
LayoutTests/fast/events/touch/gesture/touch-gesture-noscroll-body.html:67: var
scrolledElement = 'document.documentElement'
On 2013/10/08 19:25:30, Dan Beam wrote:
> nit: ; at end, also where is this used?

will add.

[tonikitoo_, 2013-10-08 20:17:43]

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/Eleme...
File
LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt
(right):

https://codereview.chromium.org/26472003/diff/3001/LayoutTests/fast/dom/Eleme...
LayoutTests/fast/dom/Element/scrollTop-scrollLeft-strict-quirks-modes-expected.txt:9:
PASS iframeStrict.contentDocument.body.scrollLeft is 4000
On 2013/10/08 19:52:32, tonikitoo_ wrote:
> On 2013/10/08 19:25:30, Dan Beam wrote:
> > ^ so wait, why are these not 0 here?
> 
> Because we restore the old behavior of document.body: it works for both strict
> and quirks modes just like before.

Ok, for the purpose of this patch, you are right. Fixed.

[Julien - ping for review, 2013-10-08 23:47:25]

description: "jQuery on propose" (purpose I suppose)

lgtm

[Dan Beam, 2013-10-08 23:50:02]

lgtm

[commit-bot: I haz the power, 2013-10-09 00:38:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/a1.gomes@sisa.samsung.com/26472003/11001

[commit-bot: I haz the power, 2013-10-09 04:51:26]

Change committed as 159195