sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart - Issue 26472002: Add TypeVariable object on runtime to support reflection on type variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

Issue 26472002: Add TypeVariable object on runtime to support reflection on type variables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

index edf808f5b97b28aa514d411ba67ea39d9d6ff7ad..552150f12edfcbed6321423e32873e574b16a001 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

@@ -291,9 +291,9 @@ class ClassEmitter extends CodeEmitterHelper {

if (backend.isNeededForReflection(classElement)) {

Link typeVars = classElement.typeVariables;

List properties = [];

- for (TypeVariableType typeVar in typeVars) {

- properties.add(js.string(typeVar.name.slowToString()));

- properties.add(js.toExpression(task.reifyType(typeVar.element.bound)));

+ if (task.typeVariableHandler.typeVariablesOf(classElement) != null) {

+ properties = task.typeVariableHandler.typeVariablesOf(classElement)

+ .map(js.toExpression);

}

ClassElement superclass = classElement.superclass;

@@ -340,11 +340,15 @@ class ClassEmitter extends CodeEmitterHelper {

buffer.write(jsAst.prettyPrint(builder.toObjectInitializer(), compiler));

String reflectionName = task.getReflectionName(classElement, className);

if (reflectionName != null) {

- List<int> interfaces = <int>[];

- for (DartType interface in classElement.interfaces) {

- interfaces.add(task.reifyType(interface));

+ if (!backend.isNeededForReflection(classElement)) {

+ buffer.write(',$n$n"+$reflectionName": 0');

+ } else {

+ List<int> interfaces = <int>[];

+ for (DartType interface in classElement.interfaces) {

+ interfaces.add(task.reifyType(interface));

+ }

+ buffer.write(',$n$n"+$reflectionName": $interfaces');

}

- buffer.write(',$n$n"+$reflectionName": $interfaces');

}