sdk/lib/_internal/compiler/implementation/ssa/builder.dart - Issue 26472002: Add TypeVariable object on runtime to support reflection on type variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 26472002: Add TypeVariable object on runtime to support reflection on type variables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart ('K') | « sdk/lib/_internal/compiler/implementation/resolution/members.dart ('k') | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | sdk/lib/_internal/lib/js_mirrors.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

index af661e7c19e99ca23658aedf20eda7ed7b5a8998..5d89f3f054d8129a223954dad5ba149e09c496c0 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

@@ -2830,7 +2830,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

bool first = true;

List<String> templates = <String>[];

for (DartType argument in interface.typeArguments) {

- templates.add(rti.getTypeRepresentation(argument, (variable) {

+ templates.add(rti.getTypeRepresentationWithHashes(argument, (variable) {

HInstruction runtimeType = addTypeVariableReference(variable);

inputs.add(runtimeType);

}));

@@ -3528,7 +3528,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

List<HInstruction> inputs = <HInstruction>[];

- String template = rti.getTypeRepresentation(argument, (variable) {

+ String template = rti.getTypeRepresentationWithHashes(argument, (variable) {

inputs.add(addTypeVariableReference(variable));

});