Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: Source/web/WebPagePopupImpl.cpp

Issue 264713014: Remove the composited path from WebViewImpl::paint(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: paint-compositor: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/WebPagePopupImpl.h ('k') | Source/web/WebPopupMenuImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 { 313 {
314 setIsAcceleratedCompositingActive(false); 314 setIsAcceleratedCompositingActive(false);
315 m_layerTreeView = 0; 315 m_layerTreeView = 0;
316 } 316 }
317 317
318 void WebPagePopupImpl::layout() 318 void WebPagePopupImpl::layout()
319 { 319 {
320 PageWidgetDelegate::layout(m_page.get()); 320 PageWidgetDelegate::layout(m_page.get());
321 } 321 }
322 322
323 void WebPagePopupImpl::paint(WebCanvas* canvas, const WebRect& rect, PaintOption s) 323 void WebPagePopupImpl::paint(WebCanvas* canvas, const WebRect& rect)
324 { 324 {
325 if (!m_closing) 325 if (!m_closing)
326 PageWidgetDelegate::paint(m_page.get(), 0, canvas, rect, PageWidgetDeleg ate::Opaque); 326 PageWidgetDelegate::paint(m_page.get(), 0, canvas, rect, PageWidgetDeleg ate::Opaque);
327 } 327 }
328 328
329 void WebPagePopupImpl::resize(const WebSize& newSize) 329 void WebPagePopupImpl::resize(const WebSize& newSize)
330 { 330 {
331 m_windowRectInScreen = WebRect(m_windowRectInScreen.x, m_windowRectInScreen. y, newSize.width, newSize.height); 331 m_windowRectInScreen = WebRect(m_windowRectInScreen.x, m_windowRectInScreen. y, newSize.width, newSize.height);
332 m_widgetClient->setWindowRect(m_windowRectInScreen); 332 m_widgetClient->setWindowRect(m_windowRectInScreen);
333 333
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 // A WebPagePopupImpl instance usually has two references. 418 // A WebPagePopupImpl instance usually has two references.
419 // - One owned by the instance itself. It represents the visible widget. 419 // - One owned by the instance itself. It represents the visible widget.
420 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 420 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
421 // WebPagePopupImpl to close. 421 // WebPagePopupImpl to close.
422 // We need them because the closing operation is asynchronous and the widget 422 // We need them because the closing operation is asynchronous and the widget
423 // can be closed while the WebViewImpl is unaware of it. 423 // can be closed while the WebViewImpl is unaware of it.
424 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 424 return adoptRef(new WebPagePopupImpl(client)).leakRef();
425 } 425 }
426 426
427 } // namespace blink 427 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/WebPagePopupImpl.h ('k') | Source/web/WebPopupMenuImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698