Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 264713013: Allow overriding Google doodle URL on Android. (Closed)

Created:
6 years, 7 months ago by newt (away)
Modified:
6 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Visibility:
Public.

Description

Allow overriding Google doodle URL on Android. This makes the LogoService respect the --google-base-url command line flag when determining the URL from which to download Google doodles. This allows easier manual testing of the doodle: if there's a doodle in France today, set the flag --google-base-url=https://www.google.fr and the current google in France will be shown. BUG=369676 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/android/logo_service.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
newt (away)
PTAL
6 years, 7 months ago (2014-05-02 22:20:57 UTC) #1
Ted C
lgtm
6 years, 7 months ago (2014-05-02 22:25:50 UTC) #2
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 7 months ago (2014-05-02 22:39:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/264713013/1
6 years, 7 months ago (2014-05-02 22:39:35 UTC) #4
newt (away)
The CQ bit was unchecked by newt@chromium.org
6 years, 7 months ago (2014-05-03 00:28:29 UTC) #5
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 7 months ago (2014-05-03 00:28:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/264713013/1
6 years, 7 months ago (2014-05-03 00:29:02 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 00:29:40 UTC) #8
Message was sent while issue was closed.
Change committed as 267991

Powered by Google App Engine
This is Rietveld 408576698