ServiceWorker: Implement DeleteAllDataForOrigin() in ServiceWorkerDatabase

ServiceWorker: Implement DeleteAllDataForOrigin() in ServiceWorkerDatabase


BUG=364099
TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.DeleteAllDataForOrigin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268581

[nhiroki, 2014-05-02 16:28:04]

Hi, can you take a look? Thanks!

https://codereview.chromium.org/264713011/diff/70001/content/browser/service_...
File content/browser/service_worker/service_worker_database.cc (right):

https://codereview.chromium.org/264713011/diff/70001/content/browser/service_...
content/browser/service_worker/service_worker_database.cc:534: // Delete until
the iterator reaches the end of records.
Is this expected behavior? I wonder if you want to delete only registration
related data, that is, not want to delete "next xxx ids" and
"uncommitted/purgeable lists".

[jsbell, 2014-05-02 17:32:55]

https://codereview.chromium.org/264713011/diff/70001/content/browser/service_...
File content/browser/service_worker/service_worker_database.cc (right):

https://codereview.chromium.org/264713011/diff/70001/content/browser/service_...
content/browser/service_worker/service_worker_database.cc:534: // Delete until
the iterator reaches the end of records.
If we're going to delete everything, why not just delete the database and
recreate it (or let it be recreated on next use)?

If we do keep this approach, you may want to consider forcing a compaction after
the batch commits to really free up the space on disk - depends on what the
intent of this function really is. But note
https://code.google.com/p/leveldb/issues/detail?id=221

[michaeln, 2014-05-05 21:46:36]

DeleteAllDataForOrigin look great

https://codereview.chromium.org/264713011/diff/70001/content/browser/service_...
File content/browser/service_worker/service_worker_database.cc (right):

https://codereview.chromium.org/264713011/diff/70001/content/browser/service_...
content/browser/service_worker/service_worker_database.cc:534: // Delete until
the iterator reaches the end of records.
On 2014/05/02 17:32:56, jsbell wrote:
> If we're going to delete everything, why not just delete the database and
> recreate it (or let it be recreated on next use)?

Right, we probably don't need this method at all. Remove it for now?

[nhiroki, 2014-05-06 15:11:32]

Updated. Can you take another look? Thanks.

https://codereview.chromium.org/264713011/diff/70001/content/browser/service_...
File content/browser/service_worker/service_worker_database.cc (right):

https://codereview.chromium.org/264713011/diff/70001/content/browser/service_...
content/browser/service_worker/service_worker_database.cc:534: // Delete until
the iterator reaches the end of records.
On 2014/05/05 21:46:36, michaeln wrote:
> On 2014/05/02 17:32:56, jsbell wrote:
> > If we're going to delete everything, why not just delete the database and
> > recreate it (or let it be recreated on next use)?
> 
> Right, we probably don't need this method at all. Remove it for now?

Okay, removed.

[michaeln, 2014-05-06 18:32:42]

lgtm

[nhiroki, 2014-05-06 18:55:22]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2014-05-06 18:56:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nhiroki@chromium.org/264713011/130001

[commit-bot: I haz the power, 2014-05-06 19:18:42]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium

[commit-bot: I haz the power, 2014-05-06 19:24:03]

Change committed as 268581