Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 264713011: ServiceWorker: Implement DeleteAllDataForOrigin() in ServiceWorkerDatabase (Closed)

Created:
6 years, 7 months ago by nhiroki
Modified:
6 years, 7 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker: Implement DeleteAllDataForOrigin() in ServiceWorkerDatabase BUG=364099 TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.DeleteAllDataForOrigin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268581

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Drop DeleteAllData() and add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_database.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_database.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_database_unittest.cc View 1 3 chunks +90 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nhiroki
Hi, can you take a look? Thanks! https://codereview.chromium.org/264713011/diff/70001/content/browser/service_worker/service_worker_database.cc File content/browser/service_worker/service_worker_database.cc (right): https://codereview.chromium.org/264713011/diff/70001/content/browser/service_worker/service_worker_database.cc#newcode534 content/browser/service_worker/service_worker_database.cc:534: // Delete ...
6 years, 7 months ago (2014-05-02 16:28:04 UTC) #1
jsbell
https://codereview.chromium.org/264713011/diff/70001/content/browser/service_worker/service_worker_database.cc File content/browser/service_worker/service_worker_database.cc (right): https://codereview.chromium.org/264713011/diff/70001/content/browser/service_worker/service_worker_database.cc#newcode534 content/browser/service_worker/service_worker_database.cc:534: // Delete until the iterator reaches the end of ...
6 years, 7 months ago (2014-05-02 17:32:55 UTC) #2
michaeln
DeleteAllDataForOrigin look great https://codereview.chromium.org/264713011/diff/70001/content/browser/service_worker/service_worker_database.cc File content/browser/service_worker/service_worker_database.cc (right): https://codereview.chromium.org/264713011/diff/70001/content/browser/service_worker/service_worker_database.cc#newcode534 content/browser/service_worker/service_worker_database.cc:534: // Delete until the iterator reaches ...
6 years, 7 months ago (2014-05-05 21:46:36 UTC) #3
nhiroki
Updated. Can you take another look? Thanks. https://codereview.chromium.org/264713011/diff/70001/content/browser/service_worker/service_worker_database.cc File content/browser/service_worker/service_worker_database.cc (right): https://codereview.chromium.org/264713011/diff/70001/content/browser/service_worker/service_worker_database.cc#newcode534 content/browser/service_worker/service_worker_database.cc:534: // Delete ...
6 years, 7 months ago (2014-05-06 15:11:32 UTC) #4
michaeln
lgtm
6 years, 7 months ago (2014-05-06 18:32:42 UTC) #5
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 7 months ago (2014-05-06 18:55:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/264713011/130001
6 years, 7 months ago (2014-05-06 18:56:38 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-06 19:18:42 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 19:24:03 UTC) #9
Message was sent while issue was closed.
Change committed as 268581

Powered by Google App Engine
This is Rietveld 408576698