Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.cc

Issue 264713008: options: fix content settings exceptions dialog regression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/content_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc
index b672cbd3d1aee21449be5ef19595da3be1e4d613..f7da58e276225e2baca2ad66c75be9de23317433 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc
@@ -1209,9 +1209,9 @@ void ContentSettingsHandler::RemoveExceptionFromHostContentSettingsMap(
rv = args->GetString(2, &pattern);
DCHECK(rv);
- // The third argument to this handler is optional.
+ // The fourth argument to this handler is optional.
std::string secondary_pattern;
- if (args->GetSize() == 3U) {
+ if (args->GetSize() >= 4U) {
Dan Beam 2014/05/01 23:43:33 ^ the fix that took me 3s to write
Lei Zhang 2014/05/01 23:54:30 Curious, what's args->GetString(0, &foo) ?
Dan Beam 2014/05/02 00:43:15 see below
rv = args->GetString(3, &secondary_pattern);
DCHECK(rv);
}

Powered by Google App Engine
This is Rietveld 408576698