Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: pkg/compiler/lib/src/js_backend/minify_namer.dart

Issue 2647043002: Fix hints reported by analyzer. (Closed)
Patch Set: Address review comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/minify_namer.dart
diff --git a/pkg/compiler/lib/src/js_backend/minify_namer.dart b/pkg/compiler/lib/src/js_backend/minify_namer.dart
index f0fdcb872fd88b4f828890ed2e68e4301ef04cf3..2871687c17c53e6c817ba3b65e2b3f808a121cfe 100644
--- a/pkg/compiler/lib/src/js_backend/minify_namer.dart
+++ b/pkg/compiler/lib/src/js_backend/minify_namer.dart
@@ -317,25 +317,20 @@ class _ConstructorBodyNamingScope {
int get numberOfConstructors => _constructors.length;
- _ConstructorBodyNamingScope _superScope;
-
_ConstructorBodyNamingScope.rootScope(ClassElement cls)
- : _superScope = null,
- _startIndex = 0,
+ : _startIndex = 0,
_constructors = cls.constructors.toList(growable: false);
_ConstructorBodyNamingScope.forClass(
ClassElement cls, _ConstructorBodyNamingScope superScope)
- : _superScope = superScope,
- _startIndex = superScope._startIndex + superScope.numberOfConstructors,
+ : _startIndex = superScope._startIndex + superScope.numberOfConstructors,
_constructors = cls.constructors.toList(growable: false);
// Mixin Applications have constructors but we never generate code for them,
// so they do not count in the inheritance chain.
_ConstructorBodyNamingScope.forMixinApplication(
ClassElement cls, _ConstructorBodyNamingScope superScope)
- : _superScope = superScope,
- _startIndex = superScope._startIndex + superScope.numberOfConstructors,
+ : _startIndex = superScope._startIndex + superScope.numberOfConstructors,
_constructors = const [];
factory _ConstructorBodyNamingScope(ClassElement cls,
« no previous file with comments | « pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698