Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: pkg/compiler/lib/src/dart2js.dart

Issue 2647043002: Fix hints reported by analyzer. (Closed)
Patch Set: Address review comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/deferred_load.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.cmdline; 5 library dart2js.cmdline;
6 6
7 import 'dart:async' show EventSink, Future; 7 import 'dart:async' show EventSink, Future;
8 import 'dart:convert' show UTF8, LineSplitter; 8 import 'dart:convert' show UTF8, LineSplitter;
9 import 'dart:io' show exit, File, FileMode, Platform, stdin, stderr; 9 import 'dart:io' show exit, File, FileMode, Platform, stdin, stderr;
10 10
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 List<String> options = new List<String>(); 115 List<String> options = new List<String>();
116 List<String> explicitOutputArguments = <String>[]; 116 List<String> explicitOutputArguments = <String>[];
117 bool wantHelp = false; 117 bool wantHelp = false;
118 bool wantVersion = false; 118 bool wantVersion = false;
119 bool analyzeOnly = false; 119 bool analyzeOnly = false;
120 bool analyzeAll = false; 120 bool analyzeAll = false;
121 bool resolveOnly = false; 121 bool resolveOnly = false;
122 Uri resolutionOutput = currentDirectory.resolve('out.data'); 122 Uri resolutionOutput = currentDirectory.resolve('out.data');
123 bool allowNativeExtensions = false; 123 bool allowNativeExtensions = false;
124 bool trustTypeAnnotations = false; 124 bool trustTypeAnnotations = false;
125 bool trustJSInteropTypeAnnotations = false;
126 bool checkedMode = false; 125 bool checkedMode = false;
127 List<String> hints = <String>[]; 126 List<String> hints = <String>[];
128 bool verbose; 127 bool verbose;
129 bool throwOnError; 128 bool throwOnError;
130 int throwOnErrorCount; 129 int throwOnErrorCount;
131 bool showWarnings; 130 bool showWarnings;
132 bool showHints; 131 bool showHints;
133 bool enableColors; 132 bool enableColors;
134 // List of provided options that imply that output is expected. 133 // List of provided options that imply that output is expected.
135 List<String> optionsImplyCompilation = <String>[]; 134 List<String> optionsImplyCompilation = <String>[];
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 verbose = true; 235 verbose = true;
237 passThrough('--verbose'); 236 passThrough('--verbose');
238 } 237 }
239 238
240 void setTrustTypeAnnotations(String argument) { 239 void setTrustTypeAnnotations(String argument) {
241 trustTypeAnnotations = true; 240 trustTypeAnnotations = true;
242 implyCompilation(argument); 241 implyCompilation(argument);
243 } 242 }
244 243
245 void setTrustJSInteropTypeAnnotations(String argument) { 244 void setTrustJSInteropTypeAnnotations(String argument) {
246 trustJSInteropTypeAnnotations = true;
247 implyCompilation(argument); 245 implyCompilation(argument);
248 } 246 }
249 247
250 void setTrustPrimitives(String argument) { 248 void setTrustPrimitives(String argument) {
251 implyCompilation(argument); 249 implyCompilation(argument);
252 } 250 }
253 251
254 void setCheckedMode(String argument) { 252 void setCheckedMode(String argument) {
255 checkedMode = true; 253 checkedMode = true;
256 passThrough(argument); 254 passThrough(argument);
(...skipping 776 matching lines...) Expand 10 before | Expand all | Expand 10 after
1033 @override 1031 @override
1034 void close() { 1032 void close() {
1035 // Do nothing. 1033 // Do nothing.
1036 } 1034 }
1037 1035
1038 @override 1036 @override
1039 void addError(errorEvent, [StackTrace stackTrace]) { 1037 void addError(errorEvent, [StackTrace stackTrace]) {
1040 // Ignore 1038 // Ignore
1041 } 1039 }
1042 } 1040 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/deferred_load.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698