Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2647043002: Fix hints reported by analyzer. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_emitter.program_builder; 5 library dart2js.js_emitter.program_builder;
6 6
7 import '../../closure.dart' show ClosureFieldElement; 7 import '../../closure.dart' show ClosureFieldElement;
8 import '../../common.dart'; 8 import '../../common.dart';
9 import '../../common/names.dart' show Names, Selectors; 9 import '../../common/names.dart' show Names, Selectors;
10 import '../../compiler.dart' show Compiler; 10 import '../../compiler.dart' show Compiler;
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 List<Holder> holders = _registry.holders.toList(growable: false); 174 List<Holder> holders = _registry.holders.toList(growable: false);
175 175
176 bool needsNativeSupport = 176 bool needsNativeSupport =
177 _compiler.enqueuer.codegen.nativeEnqueuer.hasInstantiatedNativeClasses; 177 _compiler.enqueuer.codegen.nativeEnqueuer.hasInstantiatedNativeClasses;
178 178
179 assert(!needsNativeSupport || nativeClasses.isNotEmpty); 179 assert(!needsNativeSupport || nativeClasses.isNotEmpty);
180 180
181 List<js.TokenFinalizer> finalizers = [_task.metadataCollector]; 181 List<js.TokenFinalizer> finalizers = [_task.metadataCollector];
182 if (backend.namer is js.TokenFinalizer) { 182 if (backend.namer is js.TokenFinalizer) {
183 var namingFinalizer = backend.namer; 183 var namingFinalizer = backend.namer;
184 finalizers.add(namingFinalizer); 184 finalizers.add(namingFinalizer as js.TokenFinalizer);
185 } 185 }
186 186
187 return new Program(fragments, holders, _buildLoadMap(), _symbolsMap, 187 return new Program(fragments, holders, _buildLoadMap(), _symbolsMap,
188 _buildTypeToInterceptorMap(), _task.metadataCollector, finalizers, 188 _buildTypeToInterceptorMap(), _task.metadataCollector, finalizers,
189 needsNativeSupport: needsNativeSupport, 189 needsNativeSupport: needsNativeSupport,
190 outputContainsConstantList: collector.outputContainsConstantList, 190 outputContainsConstantList: collector.outputContainsConstantList,
191 hasIsolateSupport: backend.hasIsolateSupport); 191 hasIsolateSupport: backend.hasIsolateSupport);
192 } 192 }
193 193
194 void _markEagerClasses() { 194 void _markEagerClasses() {
(...skipping 792 matching lines...) Expand 10 before | Expand all | Expand 10 after
987 Constant constant = new Constant(name, holder, constantValue); 987 Constant constant = new Constant(name, holder, constantValue);
988 _constants[constantValue] = constant; 988 _constants[constantValue] = constant;
989 } 989 }
990 } 990 }
991 991
992 Holder _registerStaticStateHolder() { 992 Holder _registerStaticStateHolder() {
993 return _registry.registerHolder(namer.staticStateHolder, 993 return _registry.registerHolder(namer.staticStateHolder,
994 isStaticStateHolder: true); 994 isStaticStateHolder: true);
995 } 995 }
996 } 996 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698