sdk/lib/_internal/compiler/implementation/compile_time_constants.dart - Issue 26470006: Handle missing const constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

Issue 26470006: Handle missing const constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

diff --git a/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart b/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

index 8ae51fadd20f237e8c5e84d0ab72c067bcb4fa50..24b6d46f0af63cfa2da53da873443a872f1a0617 100644

--- a/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

+++ b/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

@@ -620,6 +620,9 @@ class CompileTimeConstantEvaluator extends Visitor {

Send send = node.send;

FunctionElement constructor = elements[send];

+ if (Elements.isUnresolved(constructor)) {

+ return signalNotCompileTimeConstant(node);

+ }

// TODO(ahe): This is nasty: we must eagerly analyze the

// constructor to ensure the redirectionTarget has been computed

// correctly. Find a way to avoid this.

« no previous file with comments | « no previous file | tests/language/missing_const_constructor_test.dart » ('j') | no next file with comments »