Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 26470005: SkThreadPool: tweak two little things that have been annoying me (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
Reviewers:
scroggo, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

SkThreadPool: tweak two little things that have been annoying me 1) it's pretty annoying that SkThreadPool doesn't include SkRunnable for us; 2) add wait() so we don't have to keep using SkAutoTDelete/free() to wait for completion. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11711

Patch Set 1 #

Patch Set 2 : reup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M include/utils/SkThreadPool.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/utils/SkThreadPool.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M tests/OnceTest.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/skia_test.cpp View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
7 years, 2 months ago (2013-10-10 15:42:31 UTC) #1
scroggo
On 2013/10/10 15:42:31, mtklein wrote: lgtm
7 years, 2 months ago (2013-10-10 15:51:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/26470005/4001
7 years, 2 months ago (2013-10-10 16:01:18 UTC) #3
commit-bot: I haz the power
Presubmit check for 26470005-4001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 2 months ago (2013-10-10 16:01:23 UTC) #4
scroggo
Adding reed@ to approve the public API
7 years, 2 months ago (2013-10-10 16:10:58 UTC) #5
reed1
lgtm
7 years, 2 months ago (2013-10-10 17:12:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/26470005/4001
7 years, 2 months ago (2013-10-10 17:31:31 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 18:49:10 UTC) #8
Message was sent while issue was closed.
Change committed as 11711

Powered by Google App Engine
This is Rietveld 408576698