Stop dismissing selection handles when selection is kept

third_party/WebKit/Source/core/editing/VisibleSelection.h

Index: third_party/WebKit/Source/core/editing/VisibleSelection.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h
index b8b221ca18d062cd1755df936713f3760fff55fa..103b0d56c1f2a3c28c3ad29c092fe1a075814841 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h
@@ -122,6 +122,8 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
 
   void appendTrailingWhitespace();
 
+  bool isHandleVisible() const { return m_isHandleVisible; }

[yosin_UTC9, 2017/01/20 07:54:07]

We don't need to make |VisibleSelection| to have |isHandleVisible()|.
It is only for |SelectionTemplate| and |FrameSelection|.

[1] will get rid of |m_isHandleVisible| from |FrameSelection|, Since
|SelectionEditor| hold |m_seleciton|:SelectionTemplate<DOMTree> with
|m_isHandleVisible|.


[1] 2637013002: WIP Make FrameSelection to hold non-canonicalized positions

[amaralp, 2017/01/24 03:38:29]

How will |FrameSelection::setSelectionAlgorithm()| know if the handle is visible
if
|VisibleSelection| doesn't have |isHandleVisible()|?

[Changwan Ryu, 2017/01/24 06:38:45]

Hmm… Although we want to deprecate VisibleSelection in the future, the current
setSelectionAlgorithm function takes VisibleSelection as a parameter.
FrameSelection holds on to the previous isHandleVisible value while
VisibleSelection parameter keeps the new isHandleVisible value. It is hard to
imagine how to pass the new value to setSelectionAlgorithm other than through
VisibleSelection with the current structure. Please advise.

[yosin_UTC9, 2017/01/24 07:58:27]

Just pass |isHandleVisbile| as a parameter of setSeeltionAlgorithm<T>, like:

void FrameSelection::setSelectionAlgorithm(
    const VisibleSelectionTemplate<Strategy>& newSelection,
    bool isHandleVisbile,
    SetSelectionOptions options,
    CursorAlignOnScroll align,
    TextGranularity granularity) { ... }

+
   // TODO(yosin) Most callers probably don't want these functions, but
   // are using them for historical reasons. |toNormalizedEphemeralRange()|
   // contracts the range around text, and moves the caret most backward
@@ -193,6 +195,8 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
   // TODO(yosin): Once we unify start/end and base/extent, we should get rid
   // of |m_hasTrailingWhitespace|.
   bool m_hasTrailingWhitespace : 1;
+
+  bool m_isHandleVisible : 1;  // True if handle should be visible.
 };
 
 extern template class CORE_EXTERN_TEMPLATE_EXPORT