Stop dismissing selection handles when selection is kept

third_party/WebKit/Source/core/editing/SelectionTemplate.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/SelectionTemplate.h"
 
 #include "wtf/Assertions.h"
 #include <ostream>  // NOLINT
 
 namespace blink {
 
 template <typename Strategy>
 SelectionTemplate<Strategy>::SelectionTemplate(const SelectionTemplate& other)
     : m_base(other.m_base),
       m_extent(other.m_extent),
       m_affinity(other.m_affinity),
       m_granularity(other.m_granularity),
       m_hasTrailingWhitespace(other.m_hasTrailingWhitespace),
-      m_isDirectional(other.m_isDirectional)
+      m_isDirectional(other.m_isDirectional),
+      m_isHandleVisible(other.m_isHandleVisible)

[yosin_UTC9, 2017/01/25 03:49:08]

Please move this change in another patch and test cases in
"SelectionTemplate.cpp"

[Changwan Ryu, 2017/02/08 00:40:33]

This is fixed in amaralp@'s patch.

 #if DCHECK_IS_ON()
       ,
       m_domTreeVersion(other.m_domTreeVersion)
 #endif
 {
   DCHECK(other.assertValid());
   if (!m_hasTrailingWhitespace)
     return;
   DCHECK_EQ(m_granularity, WordGranularity) << *this;
 }
 
 template <typename Strategy>
 SelectionTemplate<Strategy>::SelectionTemplate() = default;
 
 template <typename Strategy>
 bool SelectionTemplate<Strategy>::operator==(
     const SelectionTemplate& other) const {
   DCHECK(assertValid());
   DCHECK(other.assertValid());
   if (isNone())
     return other.isNone();
   if (other.isNone())
     return false;
   DCHECK_EQ(m_base.document(), other.document()) << *this << ' ' << other;
   return m_base == other.m_base && m_extent == other.m_extent &&
          m_affinity == other.m_affinity &&
          m_granularity == other.m_granularity &&
          m_hasTrailingWhitespace == other.m_hasTrailingWhitespace &&
-         m_isDirectional == other.m_isDirectional;
+         m_isDirectional == other.m_isDirectional &&
+         m_isHandleVisible == other.m_isHandleVisible;
 }
 
 template <typename Strategy>
 bool SelectionTemplate<Strategy>::operator!=(
     const SelectionTemplate& other) const {
   return !operator==(other);
 }
 
 template <typename Strategy>
 const PositionTemplate<Strategy>& SelectionTemplate<Strategy>::base() const {
@@ skipping 219 matching lines @@
   return *this;
 }
 
 template <typename Strategy>
 typename SelectionTemplate<Strategy>::Builder&
 SelectionTemplate<Strategy>::Builder::setIsDirectional(bool isDirectional) {
   m_selection.m_isDirectional = isDirectional;
   return *this;
 }
 
+template <typename Strategy>
+typename SelectionTemplate<Strategy>::Builder&
+SelectionTemplate<Strategy>::Builder::setIsHandleVisible(bool isHandleVisible) {
+  m_selection.m_isHandleVisible = isHandleVisible;
+  return *this;
+}
+
 template class CORE_TEMPLATE_EXPORT SelectionTemplate<EditingStrategy>;
 template class CORE_TEMPLATE_EXPORT
     SelectionTemplate<EditingInFlatTreeStrategy>;
 
 }  // namespace blink