Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 264693011: Various cleanups in check elimination. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Various cleanups in check elimination. - Move IsMapAccess() to HObjectAccess. - Collect the actual objects instead of HStoreNamedFields in effects, and also consider HTransitionElementsKind. - Fix ownership of HCheckMaps::maps() and HLoadNamedField::maps(). - Avoid heavy copying of the same map sets all the time during check elimination, and do something useful with the memory instead by slightly bumping the maximum number of tracked objects. - Slightly optimize UniqueSet::Contains(). R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -150 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/hydrogen-check-elimination.cc View 23 chunks +55 lines, -61 lines 0 comments Download
M src/hydrogen-escape-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 8 chunks +46 lines, -46 lines 0 comments Download
M src/hydrogen-instructions.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M src/hydrogen-load-elimination.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/unique.h View 5 chunks +25 lines, -11 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Sven, Next step towards using map stability during check elimination. PTAL -- Benedikt
6 years, 7 months ago (2014-05-05 06:47:33 UTC) #1
Sven Panne
lgtm
6 years, 7 months ago (2014-05-05 06:52:37 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-05 06:53:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21133 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698