Issue 26469003: Fix valgrind uninitialized memory complaint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26469003: Fix valgrind uninitialized memory complaint (Closed)

Created:
7 years, 2 months ago by robertphillips

Modified:
7 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Valgrind complains that the test bitmap image has uninitialized data.

Patch Set 2 : Used eraseColor #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/SurfaceTest.cpp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

reed1

https://codereview.chromium.org/26469003/diff/1/tests/SurfaceTest.cpp File tests/SurfaceTest.cpp (right): https://codereview.chromium.org/26469003/diff/1/tests/SurfaceTest.cpp#newcode87 tests/SurfaceTest.cpp:87: memset(testBitmap.getPixels(), 0, testBitmap.getSize()); testBitmap.eraseColor(0);

7 years, 2 months ago (2013-10-08 22:05:36 UTC) #2

robertphillips

7 years, 2 months ago (2013-10-08 22:15:43 UTC) #3

Message was sent while issue was closed.

committed as r11664

Expand Messages | Collapse Messages

Issue 26469003: Fix valgrind uninitialized memory complaint (Closed)

Description

Patch Set 1 #

Patch Set 2 : Used eraseColor #

Messages