Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h

Issue 2646853006: [LayoutNG] Pull out of flow candidate loop into out of flow layout part. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
index d1a7301598a7f732cc60104dc743c69eb7c4df04..901cf7ba3472f051c5e9a24c81f81ae289d01359 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
@@ -56,26 +56,13 @@ class CORE_EXPORT NGFragmentBuilder final
// builder->AddChild(fragment)
// end
//
- // Part 2: layout algorithm positions out-of-flow descendants.
- //
// builder->SetInlineSize/SetBlockSize
- // builder->GetAndClearOutOfFlowDescendantCandidates(oof_candidates);
- // NGOutOfFlowLayoutPart out_of_flow_layout(container_style,
- // builder->Size());
- // while (oof_candidates.size() > 0)
- // {
- // candidate = oof_candidates.shift();
- // if (IsContainingBlockForAbsoluteChild(style, candidate_style)) {
- // NGFragmentBase* fragment;
- // NGLogicalOffset* fragment_offset;
- // out_of_flow_layout.Layout(candidate, &fragment, &offset);
- // builder->AddChild(fragment);
- // builder->GetAndClearOutOfFlowDescendantCandidates(child_oof_candidates);
- // oof_candidates.prepend(child_oof_candidates);
- // } else {
- // builder->AddOutOfFlowDescendant();
- // }
- // }
+ //
+ // Part 2: Out-of-flow layout part positions out-of-flow descendants.
+ //
+ // NGOutOfFlowLayoutPart(container_style, builder).Run();
+ //
+ // See layout part for builder interaction.
NGFragmentBuilder& AddOutOfFlowChildCandidate(NGBlockNode*, NGLogicalOffset);
void GetAndClearOutOfFlowDescendantCandidates(WeakBoxList*,

Powered by Google App Engine
This is Rietveld 408576698