Fuchsia: Copy libraries to SDK bin directory

tools/create_sdk.py

Index: tools/create_sdk.py
diff --git a/tools/create_sdk.py b/tools/create_sdk.py
index 160844c25884f1fcbad91ab41c963850801116a1..468afce629cd443f904da8b385f14d6a9da8dfe4 100755
--- a/tools/create_sdk.py
+++ b/tools/create_sdk.py
@@ -93,6 +93,9 @@ def GetOptions():
       help='Where to output the sdk')
   options.add_option("--snapshot_location",
       help='Location of the snapshots.')
+  options.add_option("--copy_libs",
+      action="store_true", default=False,
+      help='Copy dynamically linked libraries to the SDk bin directory.')

[Petr Hosek, 2017/01/20 20:51:14]

nit: SDK

[zra, 2017/01/20 20:54:45]

Done.

   return options.parse_args()
 
 
@@ -131,6 +134,19 @@ def CopyShellScript(src_file, dest_dir):
   Copy(src, dest)
 
 
+def CopyLibs(out_dir, bin_dir):
+  for library in ['libcrypto', 'libssl']:

[siva, 2017/01/20 18:40:51]

Would there be a system version of these libraries in Fuchsia that the dart
binary can dynamically link against? In that case it would not be necessary to
copy these libraries.

[zra, 2017/01/20 18:47:35]

Yes. When running on the Fuchsia target, the libraries are in standard
locations, and there is no need to copy them. When we build the Dart SDK for the
host (linux, mac) out of the Fuchsia tree, we don't want to use the system
libraries, but rather the ones that were built out of the Fuchsia tree.

+    ext = '.so'
+    if HOST_OS == 'macos':
+      ext = '.dylib'
+    elif HOST_OS == 'win32':
+      ext = '.dll'
+    src = os.path.join(out_dir, library + ext)
+    dst = os.path.join(bin_dir, library + ext)
+    if os.path.isfile(src):
+      copyfile(src, dst)
+      copymode(src, dst)
+
 def CopyDartScripts(home, sdk_root):
   for executable in ['dart2js_sdk', 'dartanalyzer_sdk', 'dartfmt_sdk',
                      'pub_sdk', 'dartdoc', 'dartdevc_sdk']:
@@ -313,6 +329,9 @@ def Main():
   CopyAnalysisSummaries(SNAPSHOT, LIB)
   CopyDevCompilerSdk(HOME, LIB)
 
+  if options.copy_libs:
+    CopyLibs(build_dir, BIN)
+
   # Write the 'version' file
   version = utils.GetVersion()
   versionFile = open(os.path.join(SDK_tmp, 'version'), 'w')