Fuchsia: Copy libraries to SDK bin directory

Fuchsia: Copy libraries to SDK bin directory

Dart in Fuchsia-land is dynamically linked. For the SDK for the host,
that is used during the Fuchsia build for running the analyzer, etc.,
we have to put the .so's next to the binary so the dynamic linker
can find them.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/3355532f01bd7957606ebda951bcba6d1d5aadee

[zra, 2017-01-20 18:35:27]

Description was changed from

==========
Fuchsia: Copy libraries to SDK bin directory
==========

to

==========
Fuchsia: Copy libraries to SDK bin directory

Dart in Fuchsia-land is dynamically linked. For the SDK for the host,
that is used during the Fuchsia build for running the analyzer, etc.,
we have to put the .so's next to the binary so the dynamic linker
can find them.
==========

[zra, 2017-01-20 18:36:49]

zra@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-01-20 18:40:51]

https://codereview.chromium.org/2646853005/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/2646853005/diff/1/tools/create_sdk.py#newcode138
tools/create_sdk.py:138: for library in ['libcrypto', 'libssl']:
Would there be a system version of these libraries in Fuchsia that the dart
binary can dynamically link against? In that case it would not be necessary to
copy these libraries.

[zra, 2017-01-20 18:47:35]

https://codereview.chromium.org/2646853005/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/2646853005/diff/1/tools/create_sdk.py#newcode138
tools/create_sdk.py:138: for library in ['libcrypto', 'libssl']:
On 2017/01/20 18:40:51, siva wrote:
> Would there be a system version of these libraries in Fuchsia that the dart
> binary can dynamically link against? In that case it would not be necessary to
> copy these libraries.

Yes. When running on the Fuchsia target, the libraries are in standard
locations, and there is no need to copy them. When we build the Dart SDK for the
host (linux, mac) out of the Fuchsia tree, we don't want to use the system
libraries, but rather the ones that were built out of the Fuchsia tree.

[siva, 2017-01-20 20:50:10]

lgtm

[Petr Hosek, 2017-01-20 20:51:14]

phosek@chromium.org changed reviewers:
+ phosek@chromium.org

[Petr Hosek, 2017-01-20 20:51:14]

https://codereview.chromium.org/2646853005/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/2646853005/diff/1/tools/create_sdk.py#newcode98
tools/create_sdk.py:98: help='Copy dynamically linked libraries to the SDk bin
directory.')
nit: SDK

[zra, 2017-01-20 20:54:45]

https://codereview.chromium.org/2646853005/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/2646853005/diff/1/tools/create_sdk.py#newcode98
tools/create_sdk.py:98: help='Copy dynamically linked libraries to the SDk bin
directory.')
On 2017/01/20 20:51:14, Petr Hosek wrote:
> nit: SDK

Done.

[zra, 2017-01-20 21:06:38]

Description was changed from

==========
Fuchsia: Copy libraries to SDK bin directory

Dart in Fuchsia-land is dynamically linked. For the SDK for the host,
that is used during the Fuchsia build for running the analyzer, etc.,
we have to put the .so's next to the binary so the dynamic linker
can find them.
==========

to

==========
Fuchsia: Copy libraries to SDK bin directory

Dart in Fuchsia-land is dynamically linked. For the SDK for the host,
that is used during the Fuchsia build for running the analyzer, etc.,
we have to put the .so's next to the binary so the dynamic linker
can find them.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3355532f01bd7957606ebda951bcba6d1d5aadee
==========

[zra, 2017-01-20 21:06:39]

Committed patchset #3 (id:40001) manually as
3355532f01bd7957606ebda951bcba6d1d5aadee (presubmit successful).