D2MIOS: Add plumbing to query verified number and send SMS from growth server.

chrome/browser/ui/desktop_ios_promotion/sms_service_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/desktop_ios_promotion/sms_service.h"
+
+#include "base/mac/bind_objc_block.h"
+#include "base/run_loop.h"
+#include "components/signin/core/browser/fake_profile_oauth2_token_service.h"
+#include "components/signin/core/browser/fake_signin_manager.h"
+#include "components/signin/core/browser/test_signin_client.h"
+#include "net/http/http_status_code.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace DesktopIOSPromotion {

[msramek, 2017/01/27 16:38:58]

Ditto here.

[justincohen, 2017/01/27 23:06:46]

Done.

+
+namespace {
+
+// A testing web history service that does extra checks and creates a
+// TestRequest instead of a normal request.
+class TestingSMSService : public SMSService {
+ public:
+  explicit TestingSMSService(
+      ProfileOAuth2TokenService* token_service,
+      SigninManagerBase* signin_manager,
+      const scoped_refptr<net::URLRequestContextGetter>& request_context)
+      : SMSService(token_service, signin_manager, request_context) {}
+
+  ~TestingSMSService() override {}
+
+  SMSService::Request* CreateRequest(
+      const GURL& url,
+      const CompletionCallback& callback) override;
+
+  void SetNextRequestResponseData(int response_code,
+                                  const std::string& response_body) {
+    next_response_code_ = response_code;
+    next_response_body_ = response_body;
+  }
+
+ private:
+  int next_response_code_;
+  std::string next_response_body_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestingSMSService);
+};
+
+// A testing request class that allows expected values to be filled in.
+class TestRequest : public SMSService::Request {
+ public:
+  TestRequest(const SMSService::CompletionCallback& callback,
+              int response_code,
+              const std::string& response_body)
+      : callback_(callback),
+        response_code_(response_code),
+        response_body_(response_body),
+        is_pending_(false) {}
+
+  ~TestRequest() override {}
+
+  // history::Request overrides
+  bool IsPending() override { return is_pending_; }
+  int GetResponseCode() override { return response_code_; }
+  const std::string& GetResponseBody() override { return response_body_; }
+  void SetPostData(const std::string& post_data) override {
+    post_data_ = post_data;
+  }
+  void SetPostDataAndType(const std::string& post_data,
+                          const std::string& mime_type) override {
+    SetPostData(post_data);
+  }
+  void Start() override {
+    is_pending_ = true;
+    base::ThreadTaskRunnerHandle::Get()->PostTask(
+        FROM_HERE,
+        base::Bind(&TestRequest::MimicReturnFromFetch, base::Unretained(this)));
+  }
+
+  void MimicReturnFromFetch() {
+    callback_.Run(this, response_code_ == net::HTTP_OK);
+  }
+
+ private:
+  GURL url_;
+  SMSService::CompletionCallback callback_;
+  int response_code_;
+  std::string response_body_;
+  std::string post_data_;
+  bool is_pending_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestRequest);
+};
+
+SMSService::Request* TestingSMSService::CreateRequest(
+    const GURL& url,
+    const CompletionCallback& callback) {
+  SMSService::Request* request =
+      new TestRequest(callback, next_response_code_, next_response_body_);
+  return request;
+}
+
+}  // namespace
+
+// A test class used for testing the SMSService class.
+// In order for SMSService to be valid, we must have a valid
+// ProfileSyncService. Using the ProfileSyncServiceMock class allows to
+// assign specific return values as needed to make sure the web history
+// service is available.
+class SMSServiceTest : public testing::Test {
+ public:
+  SMSServiceTest()
+      : signin_client_(nullptr),
+        signin_manager_(&signin_client_, &account_tracker_),
+        url_request_context_(new net::TestURLRequestContextGetter(
+            base::ThreadTaskRunnerHandle::Get())),
+        sms_service_(&token_service_, &signin_manager_, url_request_context_) {}
+
+  ~SMSServiceTest() override {}
+
+  void TearDown() override {
+    base::RunLoop run_loop;
+    base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
+                                                  run_loop.QuitClosure());
+    run_loop.Run();
+  }
+
+  TestingSMSService* sms_service() { return &sms_service_; }
+
+  void SetNextRequestResponseData(int response_code,
+                                  const std::string& response_body) {
+    sms_service_.SetNextRequestResponseData(response_code, response_body);
+  }
+
+ private:
+  base::MessageLoop message_loop_;
+  FakeProfileOAuth2TokenService token_service_;
+  AccountTrackerService account_tracker_;
+  TestSigninClient signin_client_;
+  FakeSigninManagerBase signin_manager_;
+  scoped_refptr<net::URLRequestContextGetter> url_request_context_;
+  TestingSMSService sms_service_;
+
+  DISALLOW_COPY_AND_ASSIGN(SMSServiceTest);
+};
+
+TEST_F(SMSServiceTest, VerifyJsonData) {
+  // Test that properly formatted response with good response code returns true
+  // as expected.
+  std::string query_phone_valid =
+      "{\n\"phoneNumber\": "
+      "  [\n"
+      "    {\"phoneNumber\": \"1\"},"
+      "    {\"phoneNumber\": \"2\"}"
+      "  ]\n"
+      "}";
+  sms_service()->SetNextRequestResponseData(net::HTTP_OK, query_phone_valid);
+  sms_service()->QueryPhoneNumber(
+      base::BindBlock(^(DesktopIOSPromotion::SMSService::Request* request,

[msramek, 2017/01/27 16:38:58]

base::BindBlock is .mm code though, this doesn't look compilable.

Use base::Bind instead, followed by spinning a RunLoop to ensure that
MimicReturnFromFetch gets executed.

[justincohen, 2017/01/27 23:06:46]

Done.

+                        bool success, const std::string& number) {
+        EXPECT_TRUE(success);
+        EXPECT_EQ(number, "1");
+      }));
+  std::string send_sms_valid = "{\"phoneNumber\": \"2\"}";
+  sms_service()->SetNextRequestResponseData(net::HTTP_OK, send_sms_valid);
+  std::string promo_id = "";
+  sms_service()->SendSMS(
+      promo_id,
+      base::BindBlock(^(DesktopIOSPromotion::SMSService::Request* request,
+                        bool success, const std::string& number) {
+        EXPECT_TRUE(success);
+        EXPECT_EQ(number, "2");
+      }));
+
+  // Test that improperly formatted response returns no number.
+  std::string query_phone_invalid =
+      "{\n\"phoneNumber\": "
+      "  [\n"
+      "  ]\n"
+      "}";
+  sms_service()->SetNextRequestResponseData(net::HTTP_OK, query_phone_invalid);
+  sms_service()->QueryPhoneNumber(
+      base::BindBlock(^(DesktopIOSPromotion::SMSService::Request* request,
+                        bool success, const std::string& number) {
+        EXPECT_FALSE(success);
+        EXPECT_EQ(number, "");
+      }));
+  std::string send_sms_invalid = "{}";
+  sms_service()->SetNextRequestResponseData(net::HTTP_OK, send_sms_invalid);
+  sms_service()->SendSMS(
+      promo_id,
+      base::BindBlock(^(DesktopIOSPromotion::SMSService::Request* request,
+                        bool success, const std::string& number) {
+        EXPECT_FALSE(success);
+        EXPECT_EQ(number, "");
+      }));
+}
+
+}  // namespace DesktopIOSPromotion