Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 26468005: Fix DM build failures. (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
Reviewers:
bungeman-skia, epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix DM build failures: - forgot tool_main; - skip building where skia_gpu is false; - lots of scalar -> int warnings; - stray return on a void method; - stifle warning about a uint32_t cast to bool BUG= Committed: http://code.google.com/p/skia/source/detail?r=11821

Patch Set 1 #

Patch Set 2 : tool_main #

Total comments: 2

Patch Set 3 : (int) -> SkScalarCeilToInt #

Patch Set 4 : SkToBool #

Patch Set 5 : declare tool_main #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M dm/DM.cpp View 1 2 3 4 2 chunks +8 lines, -2 lines 0 comments Download
M dm/DMCpuTask.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dm/DMGpuTask.cpp View 1 2 3 4 chunks +8 lines, -4 lines 0 comments Download
M dm/DMReplayTask.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M gyp/everything.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein
No rush.
7 years, 2 months ago (2013-10-16 15:17:01 UTC) #1
mtklein
Elliot seems to have his hands full today. Ben?
7 years, 2 months ago (2013-10-16 15:55:57 UTC) #2
bungeman-skia
https://codereview.chromium.org/26468005/diff/5001/dm/DMGpuTask.cpp File dm/DMGpuTask.cpp (right): https://codereview.chromium.org/26468005/diff/5001/dm/DMGpuTask.cpp#newcode43 dm/DMGpuTask.cpp:43: SkGpuDevice device(gr, fConfig, (int)fGM->width(), (int)fGM->height(), fSampleCount); SkScalerCeilToInt https://codereview.chromium.org/26468005/diff/5001/dm/DMGpuTask.cpp#newcode60 dm/DMGpuTask.cpp:60: ...
7 years, 2 months ago (2013-10-16 16:00:47 UTC) #3
mtklein
On 2013/10/16 16:00:47, bungeman1 wrote: > https://codereview.chromium.org/26468005/diff/5001/dm/DMGpuTask.cpp > File dm/DMGpuTask.cpp (right): > > https://codereview.chromium.org/26468005/diff/5001/dm/DMGpuTask.cpp#newcode43 > ...
7 years, 2 months ago (2013-10-16 16:05:15 UTC) #4
bungeman-skia
lgtm
7 years, 2 months ago (2013-10-16 16:06:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/26468005/12001
7 years, 2 months ago (2013-10-16 17:25:05 UTC) #6
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildEverything http://skiabot-master.pogerlabs.com:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=845
7 years, 2 months ago (2013-10-16 17:38:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/26468005/26001
7 years, 2 months ago (2013-10-16 17:38:42 UTC) #8
commit-bot: I haz the power
Change committed as 11821
7 years, 2 months ago (2013-10-16 18:21:16 UTC) #9
epoger
7 years, 2 months ago (2013-10-17 16:18:58 UTC) #10
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698