pkg/compiler/lib/src/ssa/codegen.dart - Issue 2646733006: Use entities in native_emitter.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 2646733006: Use entities in native_emitter.dart (Closed)

Patch Set: Updated cf. comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/codegen.dart

diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart

index 78a800fb26d7c292928957a81cf661ff1e6f9247..7709a20ba9426da815ce101e251d94e41895e751 100644

--- a/pkg/compiler/lib/src/ssa/codegen.dart

+++ b/pkg/compiler/lib/src/ssa/codegen.dart

@@ -2881,6 +2881,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

assert(node.isCheckedModeCheck || node.isCastTypeCheck);

DartType type = node.typeExpression;

assert(!type.isTypedef);

+ assert(!type.isDynamic);

if (type.isFunctionType) {

// TODO(5022): We currently generate $isFunction checks for

// function types.